Large difference in number of predicted species with ED Observatory

[rster2002]

The current implementation of exobiology predictions return a lot more species than elite observatory. Maybe this is caused by incorrect spawn conditions?

ED Observatory:

Journals:

[Somfic]

Happy to pick up this issue if you'd like.

I found EDMC-BioScan, which claims:

With the latest updates, BioScan can be slightly more accurate at ruling out certain bios with overlapping criteria. In a few edge cases, BioInsights may be slightly more accurate. Determining region boundaries and proximity to nebulae can be hard.

However I can't find the source of BioInsights anywhere.

[rster2002]

If you would that would be amazing! Best to branch from the state branch as I changed how spawn source is constructed a bit, but predictions logic is still the same.

[rster2002]

This is the code I bodged together to test a bit: https://gist.github.com/rster2002/3ef65973bcf9fbb89809797ace4861b5

Looking at this there should also be a check for whether the planet is landable, which it currently doesn't check.

[Somfic]

That sounds.. like a good condition to check for xd