Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify generator plugin using JProtoc #27

Open
OlegDokuka opened this issue Jan 7, 2019 · 6 comments
Open

Simplify generator plugin using JProtoc #27

OlegDokuka opened this issue Jan 7, 2019 · 6 comments

Comments

@OlegDokuka
Copy link
Member

OlegDokuka commented Jan 7, 2019

It would make it easier to support RSocket-RPC-Java plugin if it is written in a more flexible way using a templating engine like mustache or more convenient for codegen like JavaPoet.

This will simplify writing things such as #26 #20 #24

@bsideup
Copy link
Member

bsideup commented Jan 8, 2019

I guess it will also open a window for some external contributors who have no C++ knowledge and dramatically simplify the build/release process

@robertroeser
Copy link
Member

I don't want to require a JVM to generate code. C++ supports mustache templates though (https://github.com/no1msd/mstch), and you re-use this in different languages like .net, javascript, etc. Switching to mustache would probably do the most to make this easier than switching a language.

@OlegDokuka
Copy link
Member Author

Yeah, sounds good to me, will look at that

@bsideup
Copy link
Member

bsideup commented Jan 15, 2019

@robertroeser but in 99% cases rsocket-rpc-java will generate java sources during a Java build, and JVM will already be available. Isn't it so?

@bsideup
Copy link
Member

bsideup commented Jan 15, 2019

Also, I can't see how rsocket-rpc-java's (!) generator can be reused in different languages

@ilterpehlivan
Copy link

@bsideup @OlegDokuka I tried to implement an alternative Rsocket Rpc based on Salesforce Jprotoc. Additionally I also tried to simplify the API usage (similar to GRPC) by natively supporting tracing, micrometer options. I appreciate if you can take a look and give feedbacks

https://github.com/ilterpehlivan/rsocket-rpc

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants