add isSuccessful column (#241)

* add isSuccessful column

* make isSuccessful nullable

* update sql script

* bump version

Author: ivegabr

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rsk-explorer-api",
-  "version": "2.2.11",
+  "version": "2.3.0",
   "description": "RSK Explorer API",
   "main": "index.js",
   "scripts": {

prisma/rsk-explorer-database.sql

@@ -2,6 +2,9 @@
 
 /*
 
+V1.1.6 Notes:
+- add isSuccessful column to transaction table
+
 V1.1.5 Notes:
 - add status field to transaction table
 - add index on table transaction(status)
@@ -260,6 +263,7 @@ datetime TIMESTAMP WITH TIME ZONE,
 date date,
 gas_used INT,
 status VARCHAR,
+isSuccessful BOOLEAN,
 receipt VARCHAR NOT NULL, -- stringified
 CONSTRAINT fk_transaction_from FOREIGN KEY ("from") REFERENCES address(address) ON DELETE CASCADE,
 CONSTRAINT fk_transaction_to FOREIGN KEY ("to") REFERENCES address(address) ON DELETE CASCADE,
@@ -277,6 +281,10 @@ CREATE INDEX ON transaction(timestamp);
 CREATE INDEX idx_transaction_datetime ON transaction(datetime);
 CREATE INDEX idx_transaction_date ON transaction(date);
 CREATE INDEX idx_transaction_status ON transaction(status);
+CREATE INDEX idx_transaction_is_successful ON transaction(is_successful);
+CREATE INDEX idx_transaction_is_successful_to ON TRANSACTION ("to", is_successful);
+CREATE INDEX idx_transaction_is_successful_from ON TRANSACTION ("from", is_successful);
+CREATE INDEX idx_transaction_is_successful_tx_id ON TRANSACTION (tx_id, is_successful);
 
 CREATE TABLE internal_transaction (
 internal_tx_id VARCHAR PRIMARY KEY,

prisma/schema.prisma

@@ -262,6 +262,7 @@ model transaction {
   gasUsed                               Int?                     @map("gas_used")
   receipt                               String                   @db.VarChar
   status                                String?                  @db.VarChar
+  isSuccessful                          Boolean?                 @map("is_successful")
   event                                 event[]
   internal_transaction                  internal_transaction[]
   block_transaction_block_hashToblock   block                    @relation("transaction_block_hashToblock", fields: [blockHash], references: [hash], onDelete: Cascade, onUpdate: NoAction, map: "fk_transaction_block_hash")
@@ -281,6 +282,10 @@ model transaction {
   @@index([datetime], map: "idx_transaction_datetime")
   @@index([date], map: "idx_transaction_date")
   @@index([status], map: "idx_transaction_status")
+  @@index([isSuccessful], map: "idx_transaction_is_successful")
+  @@index([to, isSuccessful], map: "idx_transaction_is_successful_to")
+  @@index([from, isSuccessful], map: "idx_transaction_is_successful_from")
+  @@index([txId, isSuccessful], map: "idx_transaction_is_successful_tx_id")
 }
 
 model transaction_in_pool {

src/converters/tx.converters.js

@@ -16,6 +16,7 @@ function rawTxToEntity ({
   type,
   timestamp,
   status,
+  isSuccessful,
   receipt,
   txType,
   txId,
@@ -41,6 +42,7 @@ function rawTxToEntity ({
     type,
     timestamp,
     status,
+    isSuccessful,
     receipt: JSON.stringify(receipt),
     txType,
     txId,
@@ -69,6 +71,7 @@ function transactionEntityToRaw ({
   timestamp,
   receipt,
   status,
+  isSuccessful,
   txType,
   txId,
   datetime,
@@ -93,6 +96,7 @@ function transactionEntityToRaw ({
     type,
     timestamp: Number(timestamp),
     status,
+    isSuccessful,
     receipt: JSON.parse(receipt || '{}'),
     txType,
     txId,

src/services/classes/Tx.js

@@ -238,6 +238,7 @@ export function createTxObject (tx, { timestamp, receipt }) {
   // TODO check timestamp
   tx.timestamp = timestamp
   tx.status = receipt.status
+  tx.isSuccessful = receipt.status === '0x1'
   tx.receipt = receipt
   return tx
 }