Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSA produces slanted caps #184

Open
domier opened this issue Mar 24, 2023 · 1 comment
Open

DSA produces slanted caps #184

domier opened this issue Mar 24, 2023 · 1 comment

Comments

@domier
Copy link

domier commented Mar 24, 2023

image

Apologies if I'm missing something super basic here, but setting the keycap type to dsa produces a dsa-ish shape, but keeps the dcs slant. Is there another variable that needs to be modified to fix this, or is it an issue with the code? Setting row to 0 does not help.
@domier
Copy link
Author

domier commented Mar 28, 2023

After looking through the presets I see that for proper DSA the row needs to be set to 3.

I'd propose though that since DSA has the same profile for all rows that the correct shape should be produced regardless of the row selected - perhaps an enhancement for down the line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domier