Add one more test for overloading

Author: rrrene

test/fixtures/simple/lib/broken.rb

@@ -224,6 +224,25 @@ def params_also_in_overloads(user_options = {})
   #   @option user_options [Number] :xid an alias to transaction_id.
   def params_only_in_overloads(user_options = {})
   end
+
+  # Tests that the default signature can be present as an overload tag.
+  #
+  # @overload params_only_in_overloads()
+  #   @example
+  #     Hello.new
+  #
+  # @overload params_only_in_overloads(transaction_id)
+  #   @example
+  #     Hello.new(123)
+  #
+  # @example
+  #   Hello.new(transaction_id: 123)
+  #   Hello.new(xid: 123)
+  # @param [Hash] user_options the options to create a message with.
+  # @option user_options [Number] :transaction_id
+  # @option user_options [Number] :xid an alias to transaction_id.
+  def one_param_missing_in_overload(user_options = {})
+  end
 end
 
 module YardError

test/test_helper.rb

@@ -7,6 +7,16 @@
 Bundler.require
 require 'inch'
 
+def assert_roles(object, expected, unexpected)
+  roles = object.roles.map(&:class)
+  unexpected.each do |role|
+    refute roles.include?(role), "Should not assign #{role}"
+  end
+  expected.each do |role|
+    assert roles.include?(role), "Should assign #{role}"
+  end
+end
+
 def fixture_path(name)
   File.join(File.dirname(__FILE__), "fixtures", name.to_s)
 end

test/unit/code_object/proxy/method_object_test.rb

@@ -295,14 +295,23 @@ def test_overloading_with_bad_doc
 
   def test_overloading_with_bad_doc
     m = @objects.find("Overloading#params_only_in_overloads")
-    roles = m.roles.map(&:class)
-    bad_roles = [
+    unexpected_roles = [
       Inch::Evaluation::Role::Object::WithoutCodeExample,
       Inch::Evaluation::Role::MethodParameter::WithoutMention,
       Inch::Evaluation::Role::MethodParameter::WithoutType,
     ]
-    bad_roles.each do |role|
-      refute roles.include?(role), "Should not assign #{role}"
-    end
+    assert_roles m, [], unexpected_roles
+  end
+
+  def test_overloading_with_half_bad_doc
+    m = @objects.find("Overloading#one_param_missing_in_overload")
+    unexpected_roles = [
+      Inch::Evaluation::Role::Object::WithoutCodeExample,
+    ]
+    expected_roles = [
+      Inch::Evaluation::Role::MethodParameter::WithoutMention,
+      Inch::Evaluation::Role::MethodParameter::WithoutType,
+    ]
+    assert_roles m, expected_roles, unexpected_roles
   end
 end