Allowed q > 1 and added unit tests to check magnification #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing two conditions of
q <= 1
frommodelparameters.py
, one unit test was changed and two unit tests were added to ensure that the magnification is reproduced by the transformationsq -> 1/q
andalpha -> alpha +/- 180
.Parameters from example01 were used to test different mass ratios, except for the separation
s
, which was changed to reproduce a similar caustic crossing for binary lens.See issue #84 for more details. Comments are welcome!