Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in (t_eff, u_0) parameterization for parallax models with negative u_0 #99

Open
rpoleski opened this issue Sep 22, 2023 · 1 comment
Labels

Comments

@rpoleski
Copy link
Owner

@przemekmroz informed me that he found bug in parallax calculation for model with t_E calculated from t_eff and u_0 for negative u_0.
Trajectory calls ModelParameters.t_E for tau calculation. For this parameterization, ModelParameters.t_E returns self.t_eff / self.u_0, which is negative. We should add math.abs() in denominator or make a similar change. Other similar cases should be considered (e.g., t_E_1/2 for binary source models).

@rpoleski rpoleski added the bug label Sep 22, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Sep 25, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Sep 25, 2023
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Sep 25, 2023
rpoleski added a commit that referenced this issue Sep 29, 2023
@rpoleski
Copy link
Owner Author

@przemekmroz - issue solved.
I'm not closing this thread because there could be other similar bugs that should be corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant