Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add Coordinate Conversions #91

Open
jenniferyee opened this issue Jul 21, 2023 · 2 comments
Open

Request: Add Coordinate Conversions #91

jenniferyee opened this issue Jul 21, 2023 · 2 comments

Comments

@jenniferyee
Copy link
Collaborator

It would be helpful to have utilities to convert center of magnification <--> center of mass coordinates and also to primary as the origin. Maybe also to correct the alpha problem...

@rpoleski
Copy link
Owner

Alpha +- 180 deg. issue (i.e., fully switching to Skowron+11 conventsion) can be corrected when we go from version N.A.B to N+1.0.0 and the other changes will be significant enough that most old user codes won't work.

@rpoleski
Copy link
Owner

@jenniferyee - I've coded a version of example 16 in which you can easily use user-defined parameterization (e.g., t_0, u_0 relative to planet): link. Example 16 allows fitting models using EMCEE or pyMultiNest. If you want to use that, then let me know and I'll finish this branch, merge it, and add tutorial on how to use it for different cases. This is of course far from optimal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants