Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove calls to private functions in other classes #88

Open
rpoleski opened this issue Jun 16, 2023 · 2 comments
Open

remove calls to private functions in other classes #88

rpoleski opened this issue Jun 16, 2023 · 2 comments

Comments

@rpoleski
Copy link
Owner

In event.py we're calling:

MulensData._plot_datapoints()
MulensData._set_plot_properties()

which should not be done. Maybe there are other similar cases to correct.
@rpoleski
Copy link
Owner Author

The only other problematic case is:

  • fitdata.py -> self.model._parallax

@rpoleski
Copy link
Owner Author

The last one is solved in cb303e4. First two issues remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpoleski