You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I created a new use case for passing limb-darkening coefficients to models and proposed implementation of models.
The major issues are:
Adding "methods" and "limb_darkening_coefficients" to mm.Model.init()
Creating a new class TwoParamLimbDarkeningCoeffs that inherits from LimbDarkeningCoeffs
Passing dictionary of coefficients directly to LimbDarkeningCoeffs in init()
What to name the variables for the TwoParam case? Two parameter limb-darkening takes both Gamma and Lambda, but naming the variable "gammas_and_lambdas" seems too long, so I just stuck to "gammas" (it is also possible to implement both: one for full transparency and the other for convenience).
Next step: write unit tests, including making sure that both (Gamma, Lambda) and (c, d) implementations work the same.
Why do you want to move "methods" and "limb_darkening_coefficients" to mm.Model.__init__()?
Creating a new class TwoParamLimbDarkeningCoeffs that inherits from LimbDarkeningCoeffs
I've learned about open-closed principle recently (from the book by an author that you suggested to me :). Now I would say that both these classes should inherit from new abstract class, e.g., LimbDarkening.
Do you have any comments on the use case?
The plotting part has lots of copy-pasted code - I would prefer to avoid it.
It would be better for you to write the unit tests if I am implementing the 2-parameter limb-darkening algorithm.
I created a new use case for passing limb-darkening coefficients to models and proposed implementation of models.
The major issues are:
Next step: write unit tests, including making sure that both (Gamma, Lambda) and (c, d) implementations work the same.
@rpoleski:
The text was updated successfully, but these errors were encountered: