Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting models in fluxes #129

Closed
jenniferyee opened this issue Apr 10, 2024 · 3 comments
Closed

Plotting models in fluxes #129

jenniferyee opened this issue Apr 10, 2024 · 3 comments
Labels
enhancement help wanted quick_fix something to be fixed easily and quickly

Comments

@jenniferyee
Copy link
Collaborator

Weirdly enough, model.plot_lc does not appear to have a phot_fmt keyword. The light curve can ONLY be plotted in MAGNITUDES. Sometimes, we might want to use fluxes, so we should enable that as an option. Requires various refactoring in other functions.
@rpoleski rpoleski added enhancement help wanted quick_fix something to be fixed easily and quickly labels Apr 10, 2024
@rpoleski
Copy link
Owner

It calls Model._get_lc() which also returns magnitudes always. That one should be changed as well.

rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Apr 23, 2024
@rapoliveira
First changes to add plotting model in fluxes, issue rpoleski#129
182afdc
@rpoleski
Copy link
Owner

@jenniferyee do you suggest to add a keyword to model.plot_lc or add a function model.plot_flux?

rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Apr 24, 2024
@rapoliveira
Arranged phot_fmt keyword, examples are ok, issue rpoleski#129
a5941fa
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Apr 25, 2024
@rapoliveira
Small changes and two functions shortened, issue rpoleski#129
24e7f56
rapoliveira added a commit to rapoliveira/MulensModel that referenced this issue Apr 25, 2024
@rapoliveira
Small changes and two functions shortened, issue rpoleski#129
ca9b04d
@rapoliveira rapoliveira mentioned this issue Apr 25, 2024
Merged
@rpoleski
Copy link
Owner

@jenniferyee - it was solved by Raphael in #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted quick_fix something to be fixed easily and quickly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenniferyee @rpoleski