From e98a9829ea2a23b3a65d31b751c25ca285868a5a Mon Sep 17 00:00:00 2001 From: Radek Poleski Date: Sat, 4 May 2019 19:06:15 -0400 Subject: [PATCH] correcting description of Skowron+11 conventions --- source/MulensModel/modelparameters.py | 7 ++++--- source/MulensModel/trajectory.py | 5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/source/MulensModel/modelparameters.py b/source/MulensModel/modelparameters.py index 2e739d3b..be3ebab8 100644 --- a/source/MulensModel/modelparameters.py +++ b/source/MulensModel/modelparameters.py @@ -675,9 +675,10 @@ def alpha(self): The angle of the source trajectory relative to the binary lens axis (or primary-secondary axis). Measured counterclockwise, - i.e., according to convention advocated by `Skowron et - al. 2011 (ApJ, 738, 87) - `_. May be + i.e., according to convention advocated by + `Skowron et al. 2011 (ApJ, 738, 87) + `_, + but shifted by 180 deg. May be set as a *float* --> assumes "deg" is the default unit. Regardless of input value, returns value in degrees. """ diff --git a/source/MulensModel/trajectory.py b/source/MulensModel/trajectory.py index 8e73a404..ac842b72 100644 --- a/source/MulensModel/trajectory.py +++ b/source/MulensModel/trajectory.py @@ -23,7 +23,8 @@ class Trajectory(object): This class follows the conventions defined in Appendix A of `Skowron et al. (2011) - `_. + `_ + except the definition of *alpha*, which is shifted by 180 deg. Arguments : times: [*float*, *list*, *np.ndarray*], required @@ -164,7 +165,7 @@ def get_xy(self): vector_y = vector_tau * sin_alpha + vector_u * cos_alpha # The above equations use alpha in counterclockwise # convention, i.e., the same as proposed by Skowron et - # al. (2011) + # al. (2011), but shifted by 180 deg. else: raise NotImplementedError( "trajectory for more than 2 lenses not handled yet")