Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 12 (testing urlhelper fails) is racy #3210

Closed
ffesti opened this issue Jul 19, 2024 · 1 comment · Fixed by #3221
Closed

Test 12 (testing urlhelper fails) is racy #3210

ffesti opened this issue Jul 19, 2024 · 1 comment · Fixed by #3221
Labels
bug test Testsuite-related

Comments

@ffesti
Copy link
Contributor

ffesti commented Jul 19, 2024

There is an empty line / new line moving around.

## ---------------------- ##
## Detailed failed tests. ##
## ---------------------- ##

#                             -*- compilation -*-
12. rpmgeneral.at:401: testing urlhelper fails ...
/rpmgeneral.at:404:
runroot rpm --define "_urlhelper /bin/false" --root /srv/test -qp https://example.com/foo-0.1-1.noarch.rpm 2> >(sed 's| /.*rpm-tmp.* https| rpm-tmp https|' | sort >&2)

--- -	2024-07-05 11:50:09.240892131 +0000
+++ /srv/rpmtests.dir/at-groups/12/stderr	2024-07-05 11:50:09.238121757 +0000
@@ -1,3 +1,3 @@
+
 error: Executing url helper "/bin/false rpm-tmp https://example.com/foo-0.1-1.noarch.rpm" failed with status 1
 error: open of https://example.com/foo-0.1-1.noarch.rpm failed: No such file or directory
-
12. rpmgeneral.at:401: 12. urlhelper fails (rpmgeneral.at:401): FAILED (rpmgeneral.at:404)

Using sort as above doesn't fix it.

This has been mentioned in #3196 previously but deserves it's own ticket.

@ffesti ffesti added bug test Testsuite-related labels Jul 19, 2024
@pmatilai
Copy link
Member

I just got

+++ /srv/rpmtests.dir/at-groups/12/stderr	2024-07-30 07:20:13.111240868 +0000
@@ -1,3 +1 @@
-error: Executing url helper "/bin/false rpm-tmp https://example.com/foo-0.1-1.noarch.rpm" failed with status 1
-error: open of https://example.com/foo-0.1-1.noarch.rpm failed: No such file or directory
 
12. rpmgeneral.at:401: 12. urlhelper fails (rpmgeneral.at:401): FAILED (rpmgeneral.at:404)

Bumping this to priority, this seems to come up far more often than some of the other racy tests we've had.

pmatilai added a commit to pmatilai/rpm that referenced this issue Jul 30, 2024
/bin/false exits so fast that racing with the parent output order is
a fifty-sixty situation at best. Use a purpose-made shell script that
does a bit of IO and even sleeps a bit, which together with shell
startup time should be plenty enough to guarantee stable output for
most practical purposes. If it *still* bugs us after this, we can always
sort the output.

Fixes: rpm-software-management#3210
ffesti pushed a commit that referenced this issue Aug 5, 2024
/bin/false exits so fast that racing with the parent output order is
a fifty-sixty situation at best. Use a purpose-made shell script that
does a bit of IO and even sleeps a bit, which together with shell
startup time should be plenty enough to guarantee stable output for
most practical purposes. If it *still* bugs us after this, we can always
sort the output.

Fixes: #3210
dmnks pushed a commit to dmnks/rpm that referenced this issue Aug 29, 2024
/bin/false exits so fast that racing with the parent output order is
a fifty-sixty situation at best. Use a purpose-made shell script that
does a bit of IO and even sleeps a bit, which together with shell
startup time should be plenty enough to guarantee stable output for
most practical purposes. If it *still* bugs us after this, we can always
sort the output.

Fixes: rpm-software-management#3210
(cherry picked from commit 8e1e935)
dmnks pushed a commit that referenced this issue Aug 30, 2024
/bin/false exits so fast that racing with the parent output order is
a fifty-sixty situation at best. Use a purpose-made shell script that
does a bit of IO and even sleeps a bit, which together with shell
startup time should be plenty enough to guarantee stable output for
most practical purposes. If it *still* bugs us after this, we can always
sort the output.

Fixes: #3210
(cherry picked from commit 8e1e935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug test Testsuite-related
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants