-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro %-x modifies original flag if argument follows without intervening space #2454
Comments
See #2455 |
Looking again at case and the PR, I do think the rpm behavior to enforce a uniform output for %x is intentional and sane. The macro arguments exist for modifying macro behavior, not for passing through to other programs, and we can't allow external program requirements to set the rules for rpm macros. If you do pass an option through to some other program, it's the macros responsibility to handle any conversion needed. |
Discussed this with the team to the same conclusion, closing. |
Perhaps more to the point: rpm macros accept flag arguments with or without an intervening space. If we accepted a change to this, that would no longer be true: some macro may then require the caller to supply arguments in a certain way just because it's passed through to some other program, but the caller has no way to know that. That's why it is, and must be, the responsibility of the macro writer to handle argument passdown to other programs. |
See the following example:
The macro adds a space between flag and argument, which may affect passing to applications as shown by the following example:
Passing the option through a rpm macro returns:
Running the generated command fails:
The text was updated successfully, but these errors were encountered: