{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":31258089,"defaultBranch":"master","name":"rpm","ownerLogin":"rpm-software-management","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-02-24T12:00:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/8504469?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719217948.0","currentOid":""},"activityList":{"items":[{"before":"ea0685371f472c7591ed091a65a27f5781a1dbe0","after":"184475d40c7c05449e8da139a6c44974a9c4cae0","ref":"refs/heads/master","pushedAt":"2024-07-12T09:58:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Better error for build system issues\n\nGive different errors depending on a build system not existing at all or\nnot be defined properly. This makes it easier to detect issues in the\nbuild system declaration and no longer requires developers of new build\nsystem macros to pass --verbose to get meaningful messages.\n\nResolves: #3190","shortMessageHtmlLink":"Better error for build system issues"}},{"before":"d94dbcc24f6478719ab7e4c050362e28a1482891","after":"ea0685371f472c7591ed091a65a27f5781a1dbe0","ref":"refs/heads/master","pushedAt":"2024-07-09T11:31:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Add missing newline in sysusers Requires\n\nWithout the newline, a sysusers file like\n\n```\nu saned - \"SANE daemon user\" /etc/sane.d /bin/false\nm saned cdwriter\nm saned usb\nm saned scanner\n```\n\nResults in \"funny\" requirements\n```\ngroup(cdwriter)user(saned)\ngroup(usb)user(saned)\n```","shortMessageHtmlLink":"Add missing newline in sysusers Requires"}},{"before":"775acf13850373c16d4b0d02a1970339c381f19b","after":"d94dbcc24f6478719ab7e4c050362e28a1482891","ref":"refs/heads/master","pushedAt":"2024-07-09T11:31:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Add warning for %autopatch not applying anything\n\nIt is possible that the range given to %autopatch is not matching any\nactual patches. Issue an warning to give the packager a chance to\nrealize that there is something fishy. Not turnng this into an error to\nnot break existing builds.\n\nResolves: #3093","shortMessageHtmlLink":"Add warning for %autopatch not applying anything"}},{"before":"c00d8a0ed32169baf82cd0a34ffd1c9377b09c38","after":"775acf13850373c16d4b0d02a1970339c381f19b","ref":"refs/heads/master","pushedAt":"2024-06-26T08:42:08.000Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Drop our (t)rusty old hash table implementation\n\nIt may have been clunky to declare and non-obvious for new-comers but it\nserved us well for many years. Farewell, and thanks for all the fish.","shortMessageHtmlLink":"Drop our (t)rusty old hash table implementation"}},{"before":"3d2cc9fab2cd1b75363196ea253bf8a18f7ec0f0","after":"c00d8a0ed32169baf82cd0a34ffd1c9377b09c38","ref":"refs/heads/master","pushedAt":"2024-06-26T08:07:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace typedef's with using = for new internal C++ constructs\n\ntypedef's prevent const correctness and have various other issues,\n\"using\" is the native modern version. When in Rome...","shortMessageHtmlLink":"Replace typedef's with using = for new internal C++ constructs"}},{"before":"02a5d77029465564da33a753687a510a92906a1b","after":"3d2cc9fab2cd1b75363196ea253bf8a18f7ec0f0","ref":"refs/heads/master","pushedAt":"2024-06-26T06:46:30.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Minimally convert transaction diskspace info to STL\n\nUse an unordered map keyed by the device number for the storage, might\nbe an overkill when there typically are just a handful of filesystems\nbut shrug, that's how we access it.\n\n\"Minimally\" is in the subject because this leaves all these\nnon-idiomatic pointer accesses around, but I think it makes the change\nclearer because there are a lot of dsi->foo references in the code and\nchanging them to dsi.foo would just be a lot of churn. Changing mntPoint\ninto a string is necessary though, otherwise we'd need manual copy-control\nand all that.\n\nThis also ditches the silly rpmDiskSpaceInfo typedef and the trailing _s\nfrom diskspaceInfo, it's long enough to type as it is and the typedef\nbreaks const correctness.","shortMessageHtmlLink":"Minimally convert transaction diskspace info to STL"}},{"before":"4d1b7401415003720ea9bef7bda248f7de4fa025","after":"02a5d77029465564da33a753687a510a92906a1b","ref":"refs/heads/master","pushedAt":"2024-06-26T06:46:22.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Move DBSWAP() to bdb_ro, nothing else needs this","shortMessageHtmlLink":"Move DBSWAP() to bdb_ro, nothing else needs this"}},{"before":"1028ed35938327fc54fb89d6e6d8fc0d06fa1b07","after":"4d1b7401415003720ea9bef7bda248f7de4fa025","ref":"refs/heads/master","pushedAt":"2024-06-24T13:24:49.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Convert buildid id and path storage to STL strings in a vector\n\nThe surrounding code is full of C string manipulation but one step a\ntime, at least we get rid of dynamic arrays this way.","shortMessageHtmlLink":"Convert buildid id and path storage to STL strings in a vector"}},{"before":"4e37e714aa39b25e435a794b05819f8a99b025be","after":"2344cd81bc6e9b331d9795c88bd630fb4504cdef","ref":"refs/heads/rpm-4.20.x","pushedAt":"2024-06-24T08:31:08.000Z","pushType":"pr_merge","commitsCount":34,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Preparing for 4.20 beta1","shortMessageHtmlLink":"Preparing for 4.20 beta1"}},{"before":"e8a252dca9f0731dc5f24d91447a6906363ff9ec","after":"1028ed35938327fc54fb89d6e6d8fc0d06fa1b07","ref":"refs/heads/master","pushedAt":"2024-06-24T06:29:55.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Restore --build-in-place without %setup\n\nCommit d1075106bb315913574e1acac921058d23dd5130 made --build-in-place\nmore of a native citizen, but it also caused --build-in-place to\n*require* %setup now. There are all sorts of arguments to be made around\nthat for and against, but our overall direction has been towards making\nthings less dependent on %setup, and making this of all things require\nit seems .. counter-productive. Even more so as it previously permitted\nit to be used as a no-op.\n\nSo this effectively reverts d1075106bb315913574e1acac921058d23dd5130 and\nmoves the symlink action to %mkbuilddir instead. As a nice bonus\npractically all the business logic of build-in-place is now consolidated\ninside build.c.\n\nA somewhat surprising implication of this is that all in-place builds\nhave a %buildsubdir now: %builddir is always a thing *we* create, so\nby definition it cannot be the pre-existing directory. So the symlink\nbasically behaves as if `%setup -c -T` was used, and to match that we\nneed to define %buildsubdir as we go. And that needs to happen every\ntime we enter build, so it can't happen in doBuildDir() which can get\nskipped due to various short-circuit actions.\n\nUpdate the test-case to cover usage with and without %setup, and\n--short-circuited in-place builds.","shortMessageHtmlLink":"Restore --build-in-place without %setup"}},{"before":"ef179d65dee25ac3bd918b0259f41e73b342181e","after":"e8a252dca9f0731dc5f24d91447a6906363ff9ec","ref":"refs/heads/master","pushedAt":"2024-06-19T08:05:05.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Free cmd for --dry-run too\n\nPrevent memory leak and the memory sanatizer failing.","shortMessageHtmlLink":"Free cmd for --dry-run too"}},{"before":"8a721b69783a7bd5365a8c79ac85ccdd0b45fbad","after":"ef179d65dee25ac3bd918b0259f41e73b342181e","ref":"refs/heads/master","pushedAt":"2024-06-18T08:02:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Make the urlhelper test prefix-agnostic\n\nIn some cases like the default /usr/local the build prefix leaks to\n%_tmppath. /usr/local/var looks rather wrong anyhow but that's another\nissue, just strip it out of the test result to avoid bogus build\nfailures with other prefixes.\n\nFixes: 4c1f71ec9e171dcf29079ff80bab68d86d7d1856","shortMessageHtmlLink":"Make the urlhelper test prefix-agnostic"}},{"before":"e98aa1788714a2f0ba379e17991c293784bb0e70","after":"8a721b69783a7bd5365a8c79ac85ccdd0b45fbad","ref":"refs/heads/master","pushedAt":"2024-06-17T12:03:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Explicitly enable Doxygen on our CI builds\n\nDoxygen is present in the CI image but no longer automatically enabled\nsince commit 26a1ccf2819ab148aef3cd354e1cbdb70a9fe5b7.","shortMessageHtmlLink":"Explicitly enable Doxygen on our CI builds"}},{"before":"4c1f71ec9e171dcf29079ff80bab68d86d7d1856","after":"e98aa1788714a2f0ba379e17991c293784bb0e70","ref":"refs/heads/master","pushedAt":"2024-06-17T11:46:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Fix doc strings\n\nOtherwise these create warnings which fail the build if treated as\nerrors.","shortMessageHtmlLink":"Fix doc strings"}},{"before":"17739baf98adf30dd6dc29996427341dd6e20a3d","after":"4c1f71ec9e171dcf29079ff80bab68d86d7d1856","ref":"refs/heads/master","pushedAt":"2024-06-14T10:43:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Add error messages for url helper calls\n\nRpm allows URLs as cli parameters. The files are then automatically\ndownloaded with %_urlhelper which defaults to curl(1). So far failures\nhave been ignored right away and error messages are generated later when\nthe file was not found on disk.\n\nIssue a meaningful error message when the help program is failing or missing\ncompletely. This allows not to ship curl with rpm while still giving the\nuser a chance to find out what is going on. This is not quite ideal as\nthe operation continues and creates a second error message later on, but\nas good as it gets without redesigning the whole code.\n\nRelated: rhbz#2216754\nResolves: #2683","shortMessageHtmlLink":"Add error messages for url helper calls"}},{"before":"558793e2b92f50b08688b892d729e179110a0dcd","after":"17739baf98adf30dd6dc29996427341dd6e20a3d","ref":"refs/heads/master","pushedAt":"2024-06-14T09:05:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Fix a subtle thinko in dbiIndexItem less-than comparison\n\nThis subtlety in commit 52f311e224254d7cb28bf2ced22db7b50e1a2653 resulted\nin not-so-subtle crash due to sort going out of bounds.","shortMessageHtmlLink":"Fix a subtle thinko in dbiIndexItem less-than comparison"}},{"before":"8ad361d8047169dac3724e562411c7b561b7e6bb","after":"558793e2b92f50b08688b892d729e179110a0dcd","ref":"refs/heads/master","pushedAt":"2024-06-14T06:29:15.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Convert rpmhook table and args to STL containers\n\nSomehow this never got updated to rpmhash, so it was carrying a whole\nhash implementation on its own. Lotsa fubar goes away.\nNatively allocate rpmhook args too, and use a vector","shortMessageHtmlLink":"Convert rpmhook table and args to STL containers"}},{"before":"edbcb4501ce6f2322ee8cc1caa228c56f886a189","after":"8ad361d8047169dac3724e562411c7b561b7e6bb","ref":"refs/heads/master","pushedAt":"2024-06-14T06:29:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace digest bundle static sized array with STL map\n\nRemoves the arbitrary limit of ids we support. Not that rpm needs more,\nbut arbitrary is arbitrary. Technically it's more efficient because\nwe don't need to brute-force search and there are never inactive digests\nto skip when updating, but given the small number of elements it's\nunlikely to make any real-world difference.\n\nAlso remove the unused nbytes member, I don't recall why I added it\nbut it hasn't been grown any uses in 10+ years so might as well drop.","shortMessageHtmlLink":"Replace digest bundle static sized array with STL map"}},{"before":"52f311e224254d7cb28bf2ced22db7b50e1a2653","after":"edbcb4501ce6f2322ee8cc1caa228c56f886a189","ref":"refs/heads/master","pushedAt":"2024-06-14T05:54:44.000Z","pushType":"pr_merge","commitsCount":7,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Merge keys and update the database in rpmtsImportPubkey()","shortMessageHtmlLink":"Merge keys and update the database in rpmtsImportPubkey()"}},{"before":"d90db6ac561c92344d03615be7cd6bca18c411bb","after":"52f311e224254d7cb28bf2ced22db7b50e1a2653","ref":"refs/heads/master","pushedAt":"2024-06-13T06:57:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Replace dbiset internals with STL vector + algorithms\n\nAn always-ordered data structure might make more sense here, but for\nnow this is the lowest bar to entry.","shortMessageHtmlLink":"Replace dbiset internals with STL vector + algorithms"}},{"before":"8e1f55c7004e8c1a7d9140ab2dd9456a7ace3e77","after":"d90db6ac561c92344d03615be7cd6bca18c411bb","ref":"refs/heads/master","pushedAt":"2024-06-12T15:01:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ffesti","name":"Florian Festi","path":"/ffesti","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1306188?s=80&v=4"},"commit":{"message":"Avoid special characters from %{VERSION} in %builddir\n\n%setup always defaulted to %{name}-%{version} as the directory name,\nbut most projects would only have regular characters in their tarball\npath components (and those that did, could be expected to deal with it).\nAnd when using tilde/caret in Version you'd use `%setup -n <path>` instead.\nThis changed with the new %builddir in 4.20 where caret and tilde from\nversion leak into build paths, and nowhere near all build systems,\nhelper scripts and whatnot properly escape/quote all the paths they\nhandle. Such as apparently ninja-build, reported in\nhttps://bugzilla.redhat.com/show_bug.cgi?id=2290987\n\nConvert ^ and ~ in builddir to underscores. Note we specifically only\nconvert that for the per-package %builddir we create, if somebody sets\nthe top build directory to a path that includes such oddities, that's\nexplicitly *their* responsibility.\n\nFixes: #3159","shortMessageHtmlLink":"Avoid special characters from %{VERSION} in %builddir"}},{"before":"882c75b5a8cef5e1dc7ec6a81abca7ef7e0b93bb","after":"8e1f55c7004e8c1a7d9140ab2dd9456a7ace3e77","ref":"refs/heads/master","pushedAt":"2024-06-12T14:07:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"dmnks","name":"Michal Domonkos","path":"/dmnks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7109627?s=80&v=4"},"commit":{"message":"Talk about rpmsign in the rpmsign man page\n\nIn the past handling signatures was done by the rpm / rpmbuild binaries\ndirectly. When this functionality was split into rpmsign the man page\nwas not adjusted accoringly. This is the long overdue update.\n\nResolves: # 3125","shortMessageHtmlLink":"Talk about rpmsign in the rpmsign man page"}},{"before":"9a21826f26e8ebca3adc6be307125b5a90285c6c","after":"882c75b5a8cef5e1dc7ec6a81abca7ef7e0b93bb","ref":"refs/heads/master","pushedAt":"2024-06-12T11:59:14.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Check Source header for mandarory tags\n\nGenerating mandatory tags dynamically has them missing in SRPMs if build\nwith rpmbuid -bs or such. To prevent this from happening check the\nsource header right after the initial parse run of the spec file. This is\nmore strict than before relaxing this for the dynamic spec feature as now\nerrors can come up even if no package is actually build.\n\nExpect failure for the test case trying that and adjust failure test cases\nto not do that so the to be tested failure comes through.\n\nResolves: #3096","shortMessageHtmlLink":"Check Source header for mandarory tags"}},{"before":"1b90b8c7d176026b669ce28c6e185724a4b208b0","after":"9a21826f26e8ebca3adc6be307125b5a90285c6c","ref":"refs/heads/master","pushedAt":"2024-06-11T07:22:56.000Z","pushType":"pr_merge","commitsCount":17,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Natively allocate dbiIndexSet structs","shortMessageHtmlLink":"Natively allocate dbiIndexSet structs"}},{"before":"e69b79fa7d4757983873083a0f12164a1ad1a70b","after":"1b90b8c7d176026b669ce28c6e185724a4b208b0","ref":"refs/heads/master","pushedAt":"2024-06-11T07:21:06.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Fix potential use of uninitialized pgp struct\n\nWe only call initPgpData() after base64 encoding the pubkey so if the\nlatter fails, the kd struct will be left uninitialized and subsequently\nread from after skipping to the exit label.  Fix by initializing it.\n\nFound by Coverity.\n\nFixes: RHEL-22605","shortMessageHtmlLink":"Fix potential use of uninitialized pgp struct"}},{"before":"edcdc842c6565644e1374b9851868b18e92127ca","after":"e69b79fa7d4757983873083a0f12164a1ad1a70b","ref":"refs/heads/master","pushedAt":"2024-06-11T06:09:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Fix signfiles regression from 13a02b15d6552bc8e440235b846ea5257514d397\n\nThe sneaky construct hid more than just values starting from 1: there's\nno value 4 in rpmHashAlgo enum, so skipping that causes all the later\nhash names to be off by one.\n\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=2291183","shortMessageHtmlLink":"Fix signfiles regression from <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/rpm-software-management/rpm/commit/13a02b15d6552bc8e440235b846ea5257514d397/hovercard\" href=\"https://github.com/rpm-software-management/rpm/commit/13a02b15d6552bc8e440235b846ea5257514d397\"><tt>13a02b1</tt></a>"}},{"before":"8ab304f173379e539329aaf528920f50cee68638","after":"edcdc842c6565644e1374b9851868b18e92127ca","ref":"refs/heads/master","pushedAt":"2024-06-10T05:55:12.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Add a testcase for the undefined macro fall-through behavior\n\nThis is such a fundamental thing to all sorts of quirks around rpm\nthat it's better to have an explicit test for it.","shortMessageHtmlLink":"Add a testcase for the undefined macro fall-through behavior"}},{"before":"71e71c7b9a1100560f2f0541c83a0929425f5197","after":"8ab304f173379e539329aaf528920f50cee68638","ref":"refs/heads/master","pushedAt":"2024-06-05T11:46:01.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Add a testcase for the leaking quotes bug","shortMessageHtmlLink":"Add a testcase for the leaking quotes bug"}},{"before":"67f6bc4d9501b3db43b983ef25813a4cef8bf701","after":"71e71c7b9a1100560f2f0541c83a0929425f5197","ref":"refs/heads/master","pushedAt":"2024-06-04T05:50:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Require %{buildsubdir} to be defined to get debuginfo packages again\n\nOne of the intentions with the debuginfo enablement rework in 4.20\nwas to allow debuginfo generation on packages that don't use %setup,\nor in other words, don't have %{buildsubdir} defined. Turns out there's\njust so many things out there, relying on all these exact bits and pieces\nto be JUST SO, this causes more harm than its worth.\n\nSo bring back the requirement of %{buildsubdir} macro to be defined for\ndebuginfo generation to take place, update the caps testcase to cover\nboth. At least we can now just define buildsubdir from the spec or even\ncommand line, so the promise to have debuginfo without %setup still\nholds, it's just not automatic everywhere.","shortMessageHtmlLink":"Require %{buildsubdir} to be defined to get debuginfo packages again"}},{"before":"0310a233b953c015bd17ecfbb0e558ceaf071fc7","after":"67f6bc4d9501b3db43b983ef25813a4cef8bf701","ref":"refs/heads/master","pushedAt":"2024-06-04T05:50:15.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"pmatilai","name":"Panu Matilainen","path":"/pmatilai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3882389?s=80&v=4"},"commit":{"message":"Minimally bring back %{_buildrootdir} for backwards compatibility\n\nThis is yet another thing that specs use for purposes they shouldn't,\nin the traditional setup they don't own the top %{_buildrootdir} directory\nany more than they own %{_builddir}.\n\nWe don't want people to muck with the %{_buildrootdir} but what we can\ndo is just define it to be the dirname of %{buildroot}. This way in\nnormal use, %{_buildrootdir} equals %{builddir} which is again a safe\nplace for packages to fiddle around, and also works with --buildroot.\n\nLike %buildroot itself, this is now only ever defined inside a build,\nbecause that's the only place where it's relevant and meaningfully\ndefineable.","shortMessageHtmlLink":"Minimally bring back %{_buildrootdir} for backwards compatibility"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEfbV2GAA","startCursor":null,"endCursor":null}},"title":"Activity · rpm-software-management/rpm"}