Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pio_proc::pio_file is only picking up file changes after a cargo clean #53

Open
JomerDev opened this issue Jan 11, 2024 · 4 comments
Open

Comments

@JomerDev
Copy link

As the title says, pio_proc::pio_file seems to only pick up changes to the pio file after a cargo clean call and not otherwise.
If it is supposed to be this way I'd ask to at least reflect that in the documentation

@jannic
Copy link
Member

jannic commented Jan 11, 2024

@JomerDev I tried to reproduce this, but noticed that rust usually seems to pick up changes immediately, without needing a cargo clean. But this only works when the pio file is inside your source directory.
(I'm not saying that this isn't still a bug that should be fixed. I just try to fully understand what's happening.)

@JomerDev
Copy link
Author

I got the issue inside embassy's examples directory. The pio file was also inside the same directory next to the code.
It could of course be that calling cargo run --bin pio_uart makes rust behave differently/ignore files with paths

jannic added a commit that referenced this issue Jan 12, 2024
This works around #53. A better fix, proc_macro::tracked_path::path, is unstable.
@jannic
Copy link
Member

jannic commented Jan 12, 2024

I got the issue inside embassy's examples directory. The pio file was also inside the same directory next to the code. It could of course be that calling cargo run --bin pio_uart makes rust behave differently/ignore files with paths

Thank you, I was able to reproduce the issue. #54 should solve the issue, but is not yet tested sufficiently.

@kevinclark
Copy link

I'd love to see this get resolved. Let me know if there's anything I can do to help test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants