This repository has been archived by the owner on Jan 14, 2023. It is now read-only.
Kinetic updates #13
Merged
Kinetic updates #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonier
reviewed
Dec 16, 2016
| @@ -19,7 +19,7 @@ task wrapper(type: Wrapper) { | |||
| } | |||
|
|
|||
| buildscript { | |||
| apply from: "https://github.com/rosjava/rosjava_bootstrap/raw/indigo/buildscript.gradle" | |||
| apply from: "https://github.com/rosjava/rosjava_bootstrap/raw/kinetic/buildscript.gradle" | |||
There was a problem hiding this comment.
This is probably something that could almost be made constant and ease the release process. Damon was looking into it at some point. However probably not high priority with this (last) release. Couldn't do immediately as it points to shifting changes in the rosjava bootstrap libraries.
@adamantivm could you:
- Make an issue about this in rosjava bootstrap?
- Check that the kinetic version of the buildscript points to the right rosjava bootstrap version as a dependency
There was a problem hiding this comment.
Issue created: rosjava/rosjava_bootstrap#54
There was a problem hiding this comment.
Good catch about the dependency version: rosjava/rosjava_bootstrap#55
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version bump and added readme info