Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Notification crashes yet. #293

Open
blmhemu opened this issue Jan 18, 2019 · 6 comments
Open

Notification crashes yet. #293

blmhemu opened this issue Jan 18, 2019 · 6 comments

Comments

@blmhemu
Copy link

blmhemu commented Jan 18, 2019

Hey, although the android_core (notifications) has been updated to work with targetsdk 28, when I make an app, it still crashes. (My guess, it has not been updated in maven repo !!). The error is same as #283 . I am running Android oreo 8.1. The app (notification) responds fine when targetsdk is set to 25.

@jubeira
Copy link

jubeira commented Jan 18, 2019

Thanks for the report @blmhemu.
Note that if you are building an app and you want that fix you need to depend on android_core_components:[0.4, 0.5) instead of android_10:[0.3, 0.4) and android_15:[0.3, 0.4). If I'm not mistaken those changes are already in maven (see rosjava/rosjava_mvn_repo#62).

What artifacts are you using in your Gradle buildscript?

@blmhemu
Copy link
Author

blmhemu commented Jan 18, 2019

implementation 'org.ros.android_core:android_core_components:0.4.0' is the one i am using. Here is the build.gradle file : https://drive.google.com/drive/folders/1dZ33Vh29nI4SeLRB7IjNaCB5Krf5bD12?usp=sharing

@jubeira
Copy link

jubeira commented Jan 18, 2019

Hmm then that's weird; I don't recall seeing that. I'll take a look when I have some time. Perhaps we can incorporate your fix otherwise.

@yadajin
Copy link

yadajin commented Feb 15, 2020

Could not get resource 'https://github.com/rosjava/android_core/raw/kinetic/buildscript.gradle'.
Why does the compiler always report this error? Can you help me?

@alcabo
Copy link

alcabo commented May 18, 2020

any update over this issue?

I am also experiencing the notification issue with targetsdk 29 and implementation 'org.ros.android_core:android_core_components:0.4.0'

The notification dialog asking for shutting down crashes, leaving all ros nodes registered in the master. After a long time without working with my rosjava apps, I started updating all libraries (including android-studio, SDK, android UIs, rosjava dependencies, etc.) and eventually I noticed this problem with the shutdown.

@alcabo
Copy link

alcabo commented Jul 29, 2020

confirmed. The maven dependency is not updated.

One could download the code for android_core lib, update the NodeMainExecutorService.java with the fix by @blmhemu (https://github.com/blmhemu-rosjava/android_core/blob/kinetic/android_10/src/org/ros/android/NodeMainExecutorService.java), modify if some resource is missing (e.g., R.drawable.shutdown), compile and finally use the generated .aar in the own android ROS project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants