-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression - Python tests no longer discovered if using new setuptools. #4727
Comments
The problem is that that advice is not true in general, just sometimes. For instance, you were using the non-OS-supplied setuptools for quite a while before it broke. Further, That said, I could imagine adding an option to |
Hi, thanks for the report. I have a couple of thoughts.
In this case, colcon no longer knew what Python test tool to use for this package because Try adding this in place of 'extras_require': {
'test': [
'pytest',
],
}, If that works as expected, we should update the documentation. |
Description
My tests for an
ament_python
package are no longer being recognized. I went through a basic package creation, then followedthe python testing tutorial.
When you run
colcon test
, the tests no longer run. The test file for2+2=5
is no longer run andcolcon test
passes.Details
73.0.1
Logs
Implications
CI for ArduPIlot is no longer running our tests. This has allowed regressions to crop in our DDS interface. This is a huge issue for us.
This linked issue is here: ArduPilot/ardupilot#27925
Should we have a more clear warning that if you don't use the OS supplied setuptools, your tests won't be detected?
I'd ideally want something to throw an error if you use the new setuptools with colcon.
The text was updated successfully, but these errors were encountered: