Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.1 breaks build of downstream packages by exporting dependencies #97

Open
ottojo opened this issue Dec 6, 2022 · 0 comments
Open
Labels

Comments

@ottojo
Copy link

ottojo commented Dec 6, 2022

We use fmtlib (fmt::fmt cmake target) in our software, by downloading and building it with the rest of our software (cmake FetchContent and friends...).

We encountered a build failure using the newest humble release, which i traced back to a rouge fmt::fmt target appearing in our build (preventing us from building the latest fmtlib version ourself), transitively through rclcpp, rcl, rcl_logging and spdlog.

I'm not sure which component should or should not propagate that dependency upwards, but i think !90 is the particular change causing our problem here. I also found !60, which seems to do the exact opposite and seems convincing as well 😄

Feel free to close this as not an issue with rcl_logging, but i wanted to open an issue here as this might be a regression for more users than just us...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants