Backport #368 for Crystal #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Also needs ros2/rcutils#131 And I'm sure you've noticed the missing DCO check 😉 |
Signed-off-by: Miaofei <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
nuclearsandwich
force-pushed
the
backport-368
branch
from
ab0a8d9
to
b7f05d9
Compare
Yeah, although that looks like it was a discrepancy in the original commit between the sign-off name and the committer info. I've signed off on the backport myself but the bot is still not happy and with that. I think we're going to proceed without the DCO on this change since we clearly didn't have one on the PR it is backporting. |
jacobperron
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the test change in #368 that pairs with ros2/rmw_opensplice#260