Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider Node to Participant mapping #250

Merged
merged 11 commits into from
Jun 11, 2020
Merged

Reconsider Node to Participant mapping #250

merged 11 commits into from
Jun 11, 2020

Commits on Aug 9, 2019

  1. Add 'node to participant mapping' article 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    7b5f62f View commit details
    Browse the repository at this point in the history

  2. Address mich comments. Add rclpy container section 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    8ccaac3 View commit details
    Browse the repository at this point in the history

  3. Delete questions from document 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    d98c044 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Address per reviewer comments. Correct error in QoS for communicating… 

    … node information

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    f61eb16 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Add information about in which layer could be implemented 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    72ad690 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    2140f0d View commit details
    Browse the repository at this point in the history

  2. Address more comments 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    69790e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Cleanup document 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    b00c1b7 View commit details
    Browse the repository at this point in the history

  2. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    5d1b6c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Address peer review comments, second round 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    5c12c71 View commit details
    Browse the repository at this point in the history

  2. nit 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    cb9cd6a View commit details
    Browse the repository at this point in the history