Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release team membership #645

Open
Smith-JackSmith opened this issue Nov 12, 2024 · 7 comments
Open

Update release team membership #645

Smith-JackSmith opened this issue Nov 12, 2024 · 7 comments
Labels
needs-maintainer-links package.xml maintainer entries or other links supporting the addition of team members are needed.

Comments

@Smith-JackSmith
Copy link

Smith-JackSmith commented Nov 12, 2024

Updates to franka_robotics membership.

New team members

Current Members include

[@AndreasKuhner]
[@gomezgu]
[@BarisYazici]
[@winkma]

@nuclearsandwich nuclearsandwich added the needs-maintainer-links package.xml maintainer entries or other links supporting the addition of team members are needed. label Nov 21, 2024
@nuclearsandwich
Copy link
Collaborator

@Smith-JackSmith can you please update the issue body to include links to your maintainer entries in franka_robotics repositories. Or else have two current members of the team 👍🏼 this request.

@Smith-JackSmith
Copy link
Author

It appears I need more information - surprise - because, as far as I can see, there isn't any team named "franka_robotics_team" .

@Smith-JackSmith
Copy link
Author

Are you suggesting that I either:

1.) Edit this request, adding , into the body of the request, the GitHub user ID of the people responsible for the github repository (or group of repositories) that I wish to have access to.

Or,

2.) ask two members of the team named "franka_robotics_team" to access this github request (on GitHub) and approve it , somehow.

Both those suggestions, while sensible, imply a degree of knowledge and understanding that is not matched in reality. I'll look into this as soon as possible.

@nuclearsandwich
Copy link
Collaborator

There's an existing release team here: https://github.com/ros2-gbp/ros2-gbp-github-org/blob/latest/franka_robotics.tf

What would be the difference between the newly proposed team and this existing one?

@Smith-JackSmith
Copy link
Author

Smith-JackSmith commented Nov 22, 2024

I was told the group name "franka_robotics_release" , but, maybe there was some confusion about what it is really named.

All of the names listed in the team, "franka_robotics" - franka_robotics - appear to be the people on my development team. So, I'm pretty sure that's what is intended

@Smit-tay
Copy link

Smit-tay commented Nov 27, 2024

@nuclearsandwich

Please explain the phrase : maintainer entries in franka_robotics

Is there an GitHub attribute of a GitHub team member that is a GitHub team "maintainer", or is this at the GitHub repository level ?

Or, are you referring to this:

<maintainer email="[email protected]">Franka Robotics GmbH</maintainer>

Which I guess is the "maintainer entry" for all of Franka Robotics packages as required in package.xml

@AndreasKuhner
Copy link

Hi @nuclearsandwich ,
yes, this is the one: https://github.com/ros2-gbp/ros2-gbp-github-org/blob/latest/franka_robotics.tf - there we have our 2 new members [@Smith-JackSmith] and [@ssilenzi].

@BarisYazici can you also please thumbs up the initial post?

Cheers,
Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-maintainer-links package.xml maintainer entries or other links supporting the addition of team members are needed.
Development

No branches or pull requests

4 participants