From 386d5c5ae2b7c8014a3795c52d9e471be07e8925 Mon Sep 17 00:00:00 2001 From: Eric Cousineau Date: Tue, 20 Nov 2018 02:33:05 -0500 Subject: [PATCH] README: Consolidate; Use spaces instead of tabs Update CHANGELOG for deprecating internal XML stuff --- CHANGELOG.rst | 2 ++ README.md | 70 +++++++++++++++++++++++---------------------------- package.xml | 2 +- 3 files changed, 34 insertions(+), 40 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index aff8963..0b9714a 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -2,6 +2,8 @@ Changelog for package urdfdom_py ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +* Deprecate internal details of `xml_reflection` classes. + 0.4.0 (2018-02-21) ------------------ * Add Link.visual and Link.collision properties (`#28 `_) diff --git a/README.md b/README.md index 5d2f20c..80782bc 100644 --- a/README.md +++ b/README.md @@ -1,45 +1,37 @@ # urdf_parser_py -## Development Setup +## Authors -You must manually run `setup.py`. For catkin development, you can install to $ws/../build/lib/pythonX.Y/dist-packages via +* Thomas Moulard - `urdfpy` implementation, integration +* David Lu - `urdf_python` implementation, integration +* Kelsey Hawkins - `urdf_parser_python` implementation, integration +* Antonio El Khoury - bugfixes +* Eric Cousineau - reflection +* Ioan Sucan +* Jackie Kay +* Chris LaLancette (maintainer) +* Shane Loretz (maintainer) - devel_prefix=$(cd $(catkin_find --first-only)/.. && pwd) - cd ../urdf_parser_py - python setup.py install --install-layout deb --prefix $devel_prefix +## Features -## Authors +* URDF +* SDF (very basic coverage) +* XML Saving / Loading + * Some attempts to preserve original ordering; comments are stripped out, + however. + +## Todo + +1. Deprecate public access to `xml_reflection`. +2. Make a direct, two-way URDF <-> SDF converter when kinematics are not an + issue. + +## Development Setup + +For ease of developing, you may manually run `setup.py`. +For catkin development, you can install to +`${ws}/../build/lib/pythonX.Y/dist-packages` via: -* Thomas Moulard - `urdfpy` implementation, integration -* David Lu - `urdf_python` implementation, integration -* Kelsey Hawkins - `urdf_parser_python` implementation, integration -* Antonio El Khoury - bugfixes -* Eric Cousineau - reflection update - -## Reflection - -This an attempt to generalize the structure of the URDF via reflection to make it easier to extend. This concept is taken from Gazebo's SDF structure, and was done with SDF in mind to a) make an SDF parser and b) make a simple converter between URDF and SDF. - -### Changes - -* Features: - * Transmission and basic Gazebo nodes. - * General aggregate types, preserving order - * Dumping to YAML, used for printing to string (dictionaries do not preserve attribute ordering) -* XML Parsing: minidom has been swapped out with lxml.etree, but it should not be hard to change that back. Maybe Sax could be used for event-driven parsing. -* API: - * Loading methods rely primarily on instance methods rather than static methods, mirroring Gazebo's SDF construct-then-load method - * Renamed static `parse_xml()` to `from_xml()`, and renamed `load_*` methods to `from_*` if they are static - -### Todo - -1. Support additional formats (SDF, drakeURDF, etc.) - * Parse Gazebo's SDF definition files at some point? For speed's sake, parse it and have it generate code to use? - * Consider auto-generating modules from schemas such as [urdf.xsd](https://github.com/ros/urdfdom/blob/master/xsd/urdf.xsd). This can extend to [SDF](http://sdformat.org/schemas/model.xsd), [drakeURDF](https://github.com/RobotLocomotion/drake/blob/master/drake/doc/drakeURDF.xsd). -2. Make a direct, two-way URDF <-> SDF converter. - * Gazebo has the ability to load URDFs and save SDFs, but it lumps everything together -3. Consider a cleaner implementation for reflection. - * Make the names a little clearer, especially the fact that `from_xml` and `to_xml` write to a node, but do not create a new one. - * Abstraction layer is not clear. Should explicitly use abstract classes, and try to really clarify the dispatch order (`xmlr.Element`, `xmlr.Param`, `xmlr.Object`, etc.) -4. Figure out good policy for handling default methods. If saving to XML, write out default values, or leave them out for brevity (and to leave it open for change)? Might be best to add that as an option. -5. Find a lightweight package that can handle the reflection aspect more elegantly. Enthought traits? IPython's spinoff of traits? + devel_prefix=$(cd $(catkin_find --first-only)/.. && pwd) + cd ../urdf_parser_py + python setup.py install --install-layout deb --prefix ${devel_prefix} diff --git a/package.xml b/package.xml index ac6218e..d396400 100644 --- a/package.xml +++ b/package.xml @@ -10,7 +10,7 @@ David Lu Kelsey Hawkins Antonio El Khoury - Eric Cousineau + Eric Cousineau Ioan Sucan Jackie Kay