Add a plugin mechanism to resource_retriever #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
wjwwood
approved these changes
Aug 17, 2024
ahcorde
requested changes
Aug 19, 2024
resource_retriever/include/resource_retriever/plugins/curl_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/curl_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/filesystem_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/filesystem_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/curl_retriever.hpp
Show resolved
Hide resolved
Yadunund
reviewed
Aug 21, 2024
resource_retriever/include/resource_retriever/memory_resource.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
clalancette
requested changes
Dec 3, 2024
| { | ||
| CURLcode ret = curl_global_init(CURL_GLOBAL_ALL); | ||
| if (ret != 0) { | ||
| std::cerr << "Error initializing libcurl! retcode = " << ret; |
There was a problem hiding this comment.
Should we throw an exception here? That way we wouldn't need the initialized_ variable at all.
There was a problem hiding this comment.
I think the issue is that this is used a static global, so it's not possible to catch the exception.
However, I agree this isn't great.
I considered at least saying it should go through some injectable logging (so we could pipe it to ROS logging for example), but that's hard too since this is a global.
I think maybe it shouldn't print anything and instead it should just set the flag and the first place to try and use it should throw an exception since it's not initialized.
But I'll have to think about it more.
Comment on lines
+33
to
+39
| #include <array> | ||
| #include <cstring> | ||
| #include <iostream> | ||
| #include <memory> | ||
| #include <string> | ||
| #include <utility> | ||
| #include <vector> |
There was a problem hiding this comment.
Suggested change
| #include <array> | |
| #include <cstring> | |
| #include <iostream> | |
| #include <memory> | |
| #include <string> | |
| #include <utility> | |
| #include <vector> | |
| #include <cstring> | |
| #include <iostream> | |
| #include <memory> | |
| #include <string> | |
| #include <utility> | |
| #include <vector> |
|
|
||
| bool CurlRetriever::can_handle(const std::string & url) | ||
| { | ||
| return url.find("package://") == 0 || |
There was a problem hiding this comment.
Suggested change
| return url.find("package://") == 0 || | |
| return url.find("package://") == 0 || |
Comment on lines
+31
to
+37
| #include <array> | ||
| #include <cstring> | ||
| #include <fstream> | ||
| #include <memory> | ||
| #include <string> | ||
| #include <utility> | ||
| #include <vector> |
There was a problem hiding this comment.
Suggested change
| #include <array> | |
| #include <cstring> | |
| #include <fstream> | |
| #include <memory> | |
| #include <string> | |
| #include <utility> | |
| #include <vector> | |
| #include <fstream> | |
| #include <memory> | |
| #include <string> | |
| #include <vector> |
|
|
||
| #include "resource_retriever/plugins/retriever_plugin.hpp" | ||
|
|
||
| #include <cstring> |
There was a problem hiding this comment.
Suggested change
| #include <cstring> | |
| #include <cstring> | |
| #include <string> |
Comment on lines
31
to
35
| #include <cstring> | ||
| #include <memory> | ||
| #include <string> | ||
| #include <utility> | ||
| #include <vector> |
There was a problem hiding this comment.
Suggested change
| #include <cstring> | |
| #include <memory> | |
| #include <string> | |
| #include <utility> | |
| #include <vector> | |
| #include <memory> | |
| #include <string> | |
| #include <utility> |
| @@ -31,16 +31,26 @@ | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| #include <memory> | |
| #include <vector> |
(and alphabetize it with the above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is to make
resource_retrieverpluggable. That is that downstream users of the library can choose the mechanisms that they want to back the calls to "get".This will allow for things like retrieving over ROS services or parameters.