Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Mesa hack for 21.x ? #1701

Open
simonschmeisser opened this issue Jan 27, 2022 · 1 comment
Open

Disable Mesa hack for 21.x ? #1701

simonschmeisser opened this issue Jan 27, 2022 · 1 comment

Comments

@simonschmeisser
Copy link
Contributor

In #1508 you, @rhaschke , stated that in mesa 21.0.3 the bug requiring the old GLSL version has been fixed. Yet here https://github.com/rhaschke/rviz/blob/62ba5cd26344dceeda1b66ada5dd0740f218cbf3/src/rviz/ogre_helpers/render_system.cpp#L193 it still checks for Mesa 2x.y (including Mesa 21.y)

Should that check be limited?

I have read (but not yet confirmed) that Octomap rendering is significantly faster with the newer shaders (but I have seen slowdowns compared to older rviz versions)
@rhaschke
Copy link
Contributor

Yes, I think this workaround can be limited to Mesa < 21.0.3. Could you test this and file a PR?

@rhaschke rhaschke mentioned this issue Feb 12, 2022
Closed
@peci1 peci1 mentioned this issue Mar 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonschmeisser @rhaschke