Lazy detect transport #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mabelzhang Kindly ping to the maintainer |
|
@MatthijsBurgh @wjwwood Kindly ping to the maintainer. |
MatthijsBurgh
requested changes
Aug 30, 2023
| @@ -29,7 +29,7 @@ | |||
| <build_depend>rqt_gui</build_depend> | |||
| <build_depend>rqt_gui_cpp</build_depend> | |||
| <build_depend>sensor_msgs</build_depend> | |||
|
|
|||
| <depend>topic_tools</depend> | |||
There was a problem hiding this comment.
Depend tags are often on top. Set of the same tag are always seperated by an empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
If it cannot be detectable which transport should be used when a topic is selected,
rqt_image_viewsubscribes the topic usingtopic_tools::ShapeShifterand then determine the transport when the first message arrived.