Add interchangeable qos policies #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix mac building
Enable SHARED so plugin can find the library at runtime.
|
Thanks for proposing this improvement! However, I think defaulting to best_effort is a more straight-forward way to match any publishers. I'm more inclined to accept #67 as an alternative to this PR, especially once we enable support for overriding QoS. |
|
Closing in favor of #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows automatic configuration of subscriber QoS policies. This is important because on some networks, compressed image topics may have specific QoS profile. This PR tries to find the QoS available and sets it to default if not. It has been tested on multiple custom qos profiles and has shown to work very well without errors.