Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Turbo' does not use default scale values when axis_linear and axis_angular are set #33

Open
dave992 opened this issue Feb 3, 2020 · 0 comments

Comments

@dave992
Copy link

dave992 commented Feb 3, 2020

The documentation seems to imply that when the enable_turbo_button parameter is set correctly, the default value for scale_linear_turbo is set equal to 1.0 (scale_angular_turbo is not even mentioned). I currently encounter a case where this is not the case.

Using the following configuration teleop_ps4, the enable_turbo_button is causing the teleop_twist_joy_node to start publishing Twist messages as expected, but with all fields being zero even while receiving the correct values on the joy topic used as input.

Looking at teleop_twist_joy.cpp:77 this seems to be because the code does not use default values when axis_linear (or axis_angular) are set.

Is this intentional and does the documentation just need an update? Otherwise, I can suggest a fix for this issue and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant