Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay subscriptions are incompatible with sensor_data publishers #32

Closed
Kettenhoax opened this issue Jul 29, 2022 · 1 comment · Fixed by #34
Closed

Overlay subscriptions are incompatible with sensor_data publishers #32

Kettenhoax opened this issue Jul 29, 2022 · 1 comment · Fixed by #34

Comments

@Kettenhoax
Copy link
Contributor

The generic subscription in an overlay plugin is initialized with QoS reliability: reliable.
This makes it incompatible with sensor_data publishers.

There has been a similar discussion in rqt_image_view#41, which led the maintainers to set the default QoS to sensor_data.
Alternatively, a GUI control to set QoS could be added.
Both would solve the issue, I'm not sure about the best option though.

PS: great rqt plugin, thanks!

@ijnek
Copy link
Member

ijnek commented Jul 30, 2022

@Kettenhoax thanks for reporting the issue! I thought I had fixed that a while back in #3, but i had only changed it for the image topic and not for the overlay topics.

This should be resolved by #34, thanks for your contribution.

@ijnek ijnek closed this as completed in #34 Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants