Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port point_cloud_transport to ROS2 #1

Merged
merged 28 commits into from
Aug 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fd0aafa
First pass at ros2 conversion
john-maidbot Jun 18, 2023
b24d141
Progress
john-maidbot Jun 18, 2023
4caa745
builds without cras
john-maidbot Jun 18, 2023
8f86c97
Progress
john-maidbot Jun 19, 2023
09fc407
progress
john-maidbot Jun 19, 2023
0aafa65
Fix build errors
john-maidbot Jun 19, 2023
663feb1
progress
john-maidbot Jun 19, 2023
6d551a1
Update TODO's
john-maidbot Jun 19, 2023
4f878c2
Progress
john-maidbot Jun 19, 2023
55a86b0
More build error fixing
john-maidbot Jun 19, 2023
4758df7
Fix raw sub
john-maidbot Jun 19, 2023
8db3df2
Temporary hardcoding
john-maidbot Jun 19, 2023
64d6f71
Update usage
john-maidbot Jun 19, 2023
ccec889
Added common test (#2)
ahcorde Jun 25, 2023
a3ea8eb
Refactor republisher (#4)
ahcorde Jul 10, 2023
6fa159e
Install tl/expected in Cmake - tag a version (#5)
ahcorde Jul 10, 2023
a659059
Added dynamic parameters (#6)
ahcorde Jul 10, 2023
7833f94
Added QoS override and tests (#7)
ahcorde Jul 21, 2023
a6564c6
Allow to include param description (#9)
ahcorde Jul 21, 2023
4f8149d
Fixed subscriber filters (#10)
ahcorde Jul 21, 2023
b527a21
Windows support (#8)
ahcorde Jul 21, 2023
ce50faf
Fix pointcloud-codec and python bindings (#3)
john-maidbot Jul 25, 2023
de25c8a
Add ThirdParty folder to support building offline without FetchConten…
john-maidbot Jul 27, 2023
95bd228
Removed warnings (#15)
ahcorde Jul 27, 2023
f476edb
Use whitelist instead of blacklist (#13)
ahcorde Jul 28, 2023
b77c9bd
Updates to fix build errors (#17)
john-maidbot Aug 1, 2023
406559f
Bug fixes from porting tutorials (#18)
john-maidbot Aug 6, 2023
dc88529
One more cleanup pass (#19)
john-maidbot Aug 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/workflows/build-and-test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
#!/bin/bash
set -ev

# Configuration.
export COLCON_WS=~/ws
export COLCON_WS_SRC=${COLCON_WS}/src
export DEBIAN_FRONTEND=noninteractive
export ROS_PYTHON_VERSION=3

apt update -qq
apt install -qq -y lsb-release wget curl build-essential

# Dependencies.
echo "deb http://packages.ros.org/ros2-testing/ubuntu `lsb_release -cs` main" > /etc/apt/sources.list.d/ros2-testing.list
curl -s https://raw.githubusercontent.com/ros/rosdistro/master/ros.asc | apt-key add -
apt-get update -qq
apt-get install -y python3-colcon-common-extensions \
python3-rosdep

rosdep init
rosdep update
rosdep install --from-paths ./ -i -y -r --rosdistro $ROS_DISTRO $ROSDEP_ARGS

# Build.
source /opt/ros/$ROS_DISTRO/setup.bash
mkdir -p $COLCON_WS_SRC
cp -r $GITHUB_WORKSPACE $COLCON_WS_SRC
cd $COLCON_WS
colcon build --event-handlers console_direct+

# Tests.
colcon test --event-handlers console_direct+
colcon test-result
24 changes: 24 additions & 0 deletions .github/workflows/ros2-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: ROS2 CI

on: [push, pull_request]

jobs:
point_cloud_transport_ci:
name: point_cloud_transport CI
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- docker-image: "ubuntu:22.04"
ros-distro: "rolling"
container:
image: ${{ matrix.docker-image }}
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Build and Test
run: .github/workflows/build-and-test.sh
env:
DOCKER_IMAGE: ${{ matrix.docker-image }}
ROS_DISTRO: ${{ matrix.ros-distro }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.vscode/*
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog for package point_cloud_transport
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.0.12 (2023-06-18)
-------------------
* ROS2 port
* Contributors: John D'Angelo

1.0.11 (2023-06-16)
-------------------
* Fixed bad_expected_access error when pointcloud encoding fails.
Expand Down
Loading
Loading