Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port point_cloud_transport to ROS2 #1

Merged
merged 28 commits into from
Aug 24, 2023
Merged

Port point_cloud_transport to ROS2 #1

merged 28 commits into from
Aug 24, 2023

Commits on Jun 18, 2023

  1. First pass at ros2 conversion

    @john-maidbot
    john-maidbot committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    fd0aafa View commit details
    Browse the repository at this point in the history

  2. Progress

    @john-maidbot
    john-maidbot committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    b24d141 View commit details
    Browse the repository at this point in the history

  3. builds without cras

    @john-maidbot
    john-maidbot committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    4caa745 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Progress

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8f86c97 View commit details
    Browse the repository at this point in the history

  2. progress

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    09fc407 View commit details
    Browse the repository at this point in the history

  3. Fix build errors

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    0aafa65 View commit details
    Browse the repository at this point in the history

  4. progress

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    663feb1 View commit details
    Browse the repository at this point in the history

  5. Update TODO's

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    6d551a1 View commit details
    Browse the repository at this point in the history

  6. Progress

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4f878c2 View commit details
    Browse the repository at this point in the history

  7. More build error fixing

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    55a86b0 View commit details
    Browse the repository at this point in the history

  8. Fix raw sub

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4758df7 View commit details
    Browse the repository at this point in the history

  9. Temporary hardcoding

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8db3df2 View commit details
    Browse the repository at this point in the history

  10. Update usage

    @john-maidbot
    john-maidbot committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    64d6f71 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Added common test (#2) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    ccec889 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Refactor republisher (#4) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a3ea8eb View commit details
    Browse the repository at this point in the history

  2. Install tl/expected in Cmake - tag a version (#5) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    6fa159e View commit details
    Browse the repository at this point in the history

  3. Added dynamic parameters (#6) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a659059 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Added QoS override and tests (#7) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7833f94 View commit details
    Browse the repository at this point in the history

  2. Allow to include param description (#9) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a6564c6 View commit details
    Browse the repository at this point in the history

  3. Fixed subscriber filters (#10) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4f8149d View commit details
    Browse the repository at this point in the history

  4. Windows support (#8) 

    Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    b527a21 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix pointcloud-codec and python bindings (#3) 

    * Update topic / transport name introspection

* Fix some build errors

* Replacing shapeshifter with rclcpp::serializedmessage

* remove c_api

* consolidate bindable code into codec

* Update tests

* Get pybind working

* remove stale comments

* Fix python nodes

* doc update

* Add pybind11_vendor

* Update include/point_cloud_transport/point_cloud_codec.hpp

* Add license to pybind_codec

* param docs + standardize \param

* remove references to ros wiki

* make flake8 happy

* cpplint

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
    @john-maidbot @ahcorde
    john-maidbot and ahcorde authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ce50faf View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Add ThirdParty folder to support building offline without FetchContent ( 

    #12)

* Update package to support building offline

* Exclude thirdparty folder from ament_lint

* Suggestions to #12 - Fixed linters (#14)

* Suyggestions to #12 - Fixed linters

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* missing dependency

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
    @john-maidbot @ahcorde
    john-maidbot and ahcorde authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    de25c8a View commit details
    Browse the repository at this point in the history

  2. Removed warnings (#15) 

    Signed-off-by: Alejandro Hernández Cordero <[email protected]>
    @ahcorde
    ahcorde authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    95bd228 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Use whitelist instead of blacklist (#13) 

    * Use whitelist instead of blacklist

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Updates to param namespacing (#16)

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: john-maidbot <[email protected]>
    @ahcorde @john-maidbot
    ahcorde and john-maidbot authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    f476edb View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Updates to fix build errors (#17)

    @john-maidbot
    john-maidbot authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b77c9bd View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Bug fixes from porting tutorials (#18) 

    * Define declareParameters for raw pub/sub

* Add queue_size version of advertise

* Fix copyright linting
    @john-maidbot
    john-maidbot authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    406559f View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. One more cleanup pass (#19) 

    * Add gitignore

* Test coverage for message filter subscriber

* Remove cras expected.hpp

* Standardize docstrings

* Fix typo
    @john-maidbot
    john-maidbot authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    dc88529 View commit details
    Browse the repository at this point in the history