From 76a44b6b21e7515d7ba6c42cabf33f6451caaa03 Mon Sep 17 00:00:00 2001 From: Guillaumebeuzeboc Date: Thu, 6 Apr 2023 17:42:53 +0200 Subject: [PATCH] fix(dependency_walker): don't get dependencies of non ROS packages In case we consider non-ROS dep, we don't want to look for the ROS dependencies of non ROS packages (ie: cmake) --- src/rosdistro/dependency_walker.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/rosdistro/dependency_walker.py b/src/rosdistro/dependency_walker.py index 0f7ffa788..fda0835f8 100644 --- a/src/rosdistro/dependency_walker.py +++ b/src/rosdistro/dependency_walker.py @@ -62,6 +62,9 @@ def _get_package_names(self): def get_depends(self, pkg_name, depend_type, ros_packages_only=False): '''Return a set of package names which the package depends on.''' + # We can only get the dependencies of ROS packages + if pkg_name not in self._get_package_names(): + return set() deps = self._get_dependencies(pkg_name, depend_type) if ros_packages_only: deps &= set(self._get_package_names())