Skip to content

Commit 095c6fe

Browse files
authored
Drop references to requesting review from github-actions[bot] (#29)
I'm confident that this was working as described when I wrote this tool, but GitHub's behavior appears to have changed and requesting review from the github-actions[bot] doesn't appear to do anything anymore. We'll have to run the reviewer on push like other GitHub Actions automations.
1 parent eef582b commit 095c6fe

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

README.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,7 @@ $ rosdistro-reviewer --target-ref origin/master
2828

2929
## Running rosdistro-reviewer in GitHub Actions
3030

31-
When a [rosdistro](https://github.com/ros/rosdistro) pull request is opened on GitHub which contains changes that this tool can process, it is invoked using GitHub Actions and the resulting analysis is posted to the pull request as a review by the user `github-actions[bot]`. The rosdistro review team uses the information presented by this review to determine if proposed commits require changes before merging.
31+
When a [rosdistro](https://github.com/ros/rosdistro) pull request is opened or updated on GitHub which contains changes that this tool can process, it is invoked using GitHub Actions and the resulting analysis is posted to the pull request as a review by the user `github-actions[bot]`. The rosdistro review team uses the information presented by this review to determine if proposed commits require changes before merging.
3232

3333
| ![example GitHub pull request review](docs/github_review.png) |
3434
|-|
35-
36-
Unlike typical pull request automation, a new review will not be generated when new changes are pushed to the pull request branch. When you feel that you've sufficiently addressed the feedback given in a previous review, you should re-request review from "GitHub Actions" and a fresh analysis will be performed.
37-
38-
| ![requesting re-review from GitHub Actions](docs/github_review_request.png) |
39-
|-|

docs/github_review_request.png

-18.9 KB
Binary file not shown.

rosdistro_reviewer/submitter/github.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
ROS Distro includes a very helpful [CONTRIBUTING.md](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md) file that we recommend reading if it is your first time submitting a package.
2424
Please also read the [ROS Distro review guidelines](https://github.com/rosdistro/rosdistro/blob/master/REVIEW_GUIDELINES.md) which summarizes this release process.
2525
26-
If you'd like to run this tool again to generate a new review for your PR, [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions).
27-
2826
# ROS Distro Considerations
2927
* ROS Distributions are created using [REP-134 Standards Track](https://ros.org/reps/rep-0143.html) as a guide.
3028
* Your package name should comply to [REP-144 ROS Package Naming](https://www.ros.org/reps/rep-0144.html)

0 commit comments

Comments
 (0)