Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable rosjava_boostrap on jessie due to SSL issues #101

Merged
merged 2 commits into from
Nov 30, 2017
Merged

disable rosjava_boostrap on jessie due to SSL issues #101

merged 2 commits into from
Nov 30, 2017

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Nov 29, 2017 •
edited
Loading

@tfoote tfoote self-assigned this Nov 29, 2017
@tfoote tfoote mentioned this pull request Nov 29, 2017
Closed
@mikaelarguedas
Copy link

it looks like this failure is present on all arm builds and not only debian Jessie
http://build.ros.org/view/Kbin_uxv8_uXv8/job/Kbin_uxv8_uXv8__rosjava_bootstrap__ubuntu_xenial_arm64__binary/430/console
http://build.ros.org/view/Kbin_uxhf_uXhf/job/Kbin_uxhf_uXhf__rosjava_bootstrap__ubuntu_xenial_armhf__binary/351/console

@tfoote
Copy link
Member Author

tfoote commented Nov 29, 2017

True, it's not flagged as a regression, because I believe that they have never worked. I guess we should disable on the other arm platforms too. This package has always had trouble but was recently added as a dependency which is causing the regressions.

@ernestmc @jubeira I'm going to add the other arm platforms to the blacklist too.

mikaelarguedas
mikaelarguedas approved these changes Nov 30, 2017
View reviewed changes
Copy link

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas
Copy link

True, it's not flagged as a regression, because I believe that they have never worked.

Yeah I see a few rosjava packages in indigo that seem to have been failing on arm forever as well and would deserve the same treatment
http://repositories.ros.org/status_page/ros_indigo_arm.html?q=rosjava

@tfoote tfoote merged commit d674149 into production Nov 30, 2017
@tfoote tfoote deleted the disable_rosjava_kinetic branch November 30, 2017 00:43
@tfoote
Copy link
Member Author

tfoote commented Nov 30, 2017

They're already disabled. Unfortunately the status page doesn't know about blacklisting. It only knows they they're missing in the repo.

nuclearsandwich pushed a commit that referenced this pull request Dec 28, 2020
@tfoote @nuclearsandwich
disable rosjava_boostrap on jessie due to SSL issues (#101)
5d2604a 
* diable rosjava_boostrap on jessie due to SSL issues
rosjava/rosjava_bootstrap#61

* blacklisting rosjava_boostrap on all arm platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@tfoote tfoote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfoote @mikaelarguedas