Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dependencies #884

Open
Nir-Az opened this issue Sep 25, 2024 · 2 comments
Open

Local dependencies #884

Nir-Az opened this issue Sep 25, 2024 · 2 comments
Labels

Comments

@Nir-Az
Copy link

Nir-Az commented Sep 25, 2024

Hi guys,
Some workflow question here:
We build a ROS2 package that is dependent on another ROS2 package we have.
When we change API the industrial_ci jobs fails because it does not use the new commit API of the dependent package but the published one.

So until we will publish the dependent package the flow will always fail.
Any W/A to this issue?

Thanks,
Nir

@mathias-luedtke
Copy link
Member

You could configure your UPSTREAM/DOWNSTREAM_WORKSPACE (https://github.com/ros-industrial/industrial_ci/blob/master/doc/index.rst#workspace-management) Perhaps with a custom script, which configures the branches as needed.

But in general I would recommend to not break API, but deprecate the old one first.

@Nir-Az
Copy link
Author

Nir-Az commented Oct 6, 2024

You could configure your UPSTREAM/DOWNSTREAM_WORKSPACE (https://github.com/ros-industrial/industrial_ci/blob/master/doc/index.rst#workspace-management) Perhaps with a custom script, which configures the branches as needed.

But in general I would recommend to not break API, but deprecate the old one first.

I agree, but that's not the case here.
It's a new API for the dependency (new feature) that the ROS node will now use..
The only smooth way IMO is to release the dependency with the new API only, wait for sync and then add the new API at the ROS node (which is a bad W/A)..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants