From 9585691609e4433c0629bf1e5f1f1c1ed92c79a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20Fr=C3=B6hlich?=
 <christophfroehlich@users.noreply.github.com>
Date: Sun, 15 Jan 2023 23:08:28 +0100
Subject: [PATCH] Correct documentation (signs in PID control law) (#138)

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
---
 include/control_toolbox/pid.hpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/control_toolbox/pid.hpp b/include/control_toolbox/pid.hpp
index b536e4da..a6bc4ff4 100644
--- a/include/control_toolbox/pid.hpp
+++ b/include/control_toolbox/pid.hpp
@@ -60,7 +60,7 @@ namespace control_toolbox
   In particular, this class implements the standard
   pid equation:
 
-  \f$command  = -p_{term} - i_{term} - d_{term} \f$
+  \f$command  = p_{term} + i_{term} + d_{term} \f$
 
   where: <br>
   <UL TYPE="none">
@@ -72,7 +72,7 @@ namespace control_toolbox
 
   given:<br>
   <UL TYPE="none">
-  <LI>  \f$ p_{error}  = p_{state} - p_{target} \f$.
+  <LI>  \f$ p_{error}  = p_{desired} - p_{state} \f$.
   </UL>
 
   \param p Proportional gain
@@ -97,7 +97,7 @@ namespace control_toolbox
   ros::Time last_time = ros::Time::now();
   while (true) {
   ros::Time time = ros::Time::now();
-  double effort = pid.updatePid(currentPosition() - position_desi_, time - last_time);
+  double effort = pid.updatePid(position_desi_ - currentPosition(), time - last_time);
   last_time = time;
   }
   \endverbatim