Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit pagination to 500 #13

Open
mfenner opened this issue Jan 15, 2019 · 3 comments
Open

Limit pagination to 500 #13

mfenner opened this issue Jan 15, 2019 · 3 comments
Labels
enhancement Improvement/change to existing functionality

Comments

@mfenner
Copy link

mfenner commented Jan 15, 2019

Elasticsearch only allows paginating through 10,000 results per request. With a default per page of 20 that means 500 pages. Requesting page 501 will result in a 500 error: https://api.ror.org/organizations?query=*&page=501 (requesting page 500 works).

Suggested solution is to limit page to 500.

@mfenner mfenner added the bug Something isn't working label Jan 15, 2019
@dtkaczyk dtkaczyk self-assigned this Sep 18, 2019
@mariagould
Copy link
Contributor

@dtkaczyk can this be closed?

@dtkaczyk
Copy link
Collaborator

dtkaczyk commented May 1, 2020

I think so, yes.

@mariagould
Copy link
Contributor

mariagould commented Nov 13, 2020

Reopening. https://api.ror.org/organizations?query=*&page=501 still returns an error.

Screen Shot 2022-03-01 at 1 26 17 PM

@mariagould mariagould reopened this Nov 13, 2020
@lizkrznarich lizkrznarich removed the bug Something isn't working label Feb 7, 2022
@mariagould mariagould added the enhancement Improvement/change to existing functionality label Mar 1, 2022
@mariagould mariagould moved this to Enhancements in ROR Inbox Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement/change to existing functionality
Projects
Status: Enhancements
Development

No branches or pull requests

4 participants