Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[roq-server] Invalid order_type from exchange update would incorrectly generate an OrderAck with origin GATEWAY #480

Open
thraneh opened this issue Nov 22, 2024 · 0 comments
Open

[roq-server] Invalid order_type from exchange update would incorrectly generate an OrderAck with origin GATEWAY #480

thraneh opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working medium priority support
Milestone
1.0.5

Comments

@thraneh
Copy link
Contributor

thraneh commented Nov 22, 2024 •
edited
Loading

See #479

This is complex. All gateway checks (roq-server/oms) currently emits origin GATEWAY when some internal validation fails. This is typically indicative of a bug somewhere on our side. The error should only in truly exceptional cases be seen by the user of the software. In this case it's maybe fine with a confusing update since the user will then reach out for support.

Action: Undecided at this point.
@thraneh thraneh added bug Something isn't working medium priority support labels Nov 22, 2024
@thraneh thraneh modified the milestones: 1.0.3, 1.0.4 Nov 22, 2024
@thraneh thraneh modified the milestones: 1.0.4, 1.0.5 Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working medium priority support
Milestone
1.0.5
Development

No branches or pull requests
1 participant
@thraneh