-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to ignore location data #272
Comments
Hi, thanks for reaching out @RichardLitt The example shown in that issue using Should I jump into the conversation here or on that issue in the rebird repo? |
I logged an issue on this repo because I didn't want this to only be a support request. If the regex is the way to go, I would love help on the other repo; once that is done (and hopefully once I understand it!), I'd be happy to make a PR here to add the documentation needed to this repo to help others do this easier in the future. Then I think we could close this. |
In terms of documentation, you mentioned the README. There's also:
I'd be happy to think about what would have made this information easier to find. p.s., sort related to #82 , but actually just closed that as it'd not needed I don't think. I'll pop into the other repo to try to help |
Thanks. Something like a convenience function that just checks IP addresses might be useful. Or perhaps this could be added to https://books.ropensci.org/http-testing/vcr-security#other-security? |
In https://github.com/ropensci/rebird, which uses this plugin as a dependency, we'd like to remove IP-based location determination (see ropensci/rebird#115). Part of the issue is that vcr logs requests and stores them. I wonder if there is a way to purge IP information from a request, too, or if this all needs to be done in ropensci/rebird.
Would it be possible to add an option to ignore parts of the request? Or, as one user put it:
Thanks. If there is, I'd like to help document it here - I couldn't find a direct answer to that question in the README, although I may have missed something.
This may relate to #82.
The text was updated successfully, but these errors were encountered: