Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vignette focusing on normalisation, delta_cq, etc? from @wolski review #127

Open
ewallace opened this issue Dec 6, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ewallace
Copy link
Collaborator

ewallace commented Dec 6, 2021

Software review by @wolski ropensci/software-review#470 (comment)
Asked for addressing some key normalisation capabilities in the vignettes.

I do not know if @seaaan means the same as I when he writing "Focus on functions provided by your package and what they do and how to use them" (e.g. in the multifactorial vignette, explain at greater length about normalizeqPCR, debaseline, getRdTall)", but I would say the same.
https://discuss.ropensci.org/t/tidyqpcr-for-quantitative-pcr-analysis-pre-presubmission-community-enquiry/2056
This comment was made in May 2021 i.e., half a year ago, but I do not see any evidence of how you addressed them in the vignettes of tidyqpcr.

Do we need a new vignette focusing on normalisation, delta_cq, etc.?

@ewallace ewallace added the rOpensci-review To fix for rOpensci review, December 2021 label Dec 17, 2021
@DimmestP DimmestP self-assigned this Jan 12, 2022
@ewallace
Copy link
Collaborator Author

We said in our resubmission that we decided adding this vignette was not essential and so prioritised other things. Then @jooolia's review did not ask for it. So, this is a backlog issue that we hope to address in the future.

@ewallace ewallace added documentation Improvements or additions to documentation enhancement New feature or request and removed rOpensci-review To fix for rOpensci review, December 2021 labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants