-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem when geometry as a list and name passed together #146
Comments
a bit complicated. We can either let users loop over many names, many geometry inputs, but not both So, if many names, which is the problem here, then geometry could be collapsed to a single input. BUT, see below, none of the data sources accept a wkt So, we're forced to do a new query for each bounding box/WKT string given in this scenario wkt & bbox
bbox only
neither
|
issue opened in GBIF issue tracker to see if we can get support for more than 1 polygon passed in WKT string |
this stil needs tests added also added more details as to what happens with the diff scenarios of query/geometry parameters combined
…pty results added more tests for occ() for geometry based searches, #146
fixed now, AFAIK |
From discussion forum https://discuss.ropensci.org/t/spocc-and-bounding-boxes/233/7
Ah, there must be some interaction when you give geometry as a list and when you also give a taxon name to query. I think i've identified the line of code that's causing the problem https://github.com/ropensci/spocc/blob/master/R/occ.r#L80 - looks like when a taxon name and geometry as a character or numeric vector we're fine, but if it's a list, then it blows up.
The text was updated successfully, but these errors were encountered: