From dc613732388e8ab4c4da34f77a86dba35fd4119d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Mon, 23 Mar 2020 07:20:54 +0100 Subject: [PATCH] skip test on CRAN cf #48 and cf https://github.com/ropensci/vcr/issues/158 --- NEWS.md | 2 ++ tests/testthat/test-buildQueries.R | 2 ++ 2 files changed, 4 insertions(+) diff --git a/NEWS.md b/NEWS.md index c8f714b..b013482 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # ropenaq (development version) +* Skip a vcr-enabled test on CRAN because of a vcr problem with encoding. + # ropenaq 0.2.8 * Bug fixes (page has now a maximum argument; no longer passing an empty param in the query) diff --git a/tests/testthat/test-buildQueries.R b/tests/testthat/test-buildQueries.R index 8529f97..fc47872 100644 --- a/tests/testthat/test-buildQueries.R +++ b/tests/testthat/test-buildQueries.R @@ -79,7 +79,9 @@ test_that("Errors are thrown if the geographical arguments are wrong",{ }) test_that("Queries work with spaces and accents",{ + # Both skipping because of https://github.com/ropensci/vcr/issues/158 skip_on_os("windows") + skip_on_cran() vcr::use_cassette("buildQueries_accents", { result1 <- aq_measurements(city = "Heinz+Ott", country = "DE", limit = 1, page = 1)