Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Commit

Permalink
skip test on CRAN cf #48 and cf ropensci/vcr#158
Browse files Browse the repository at this point in the history
  • Loading branch information
maelle committed Mar 23, 2020
1 parent ad08652 commit dc61373
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# ropenaq (development version)

* Skip a vcr-enabled test on CRAN because of a vcr problem with encoding.

# ropenaq 0.2.8

* Bug fixes (page has now a maximum argument; no longer passing an empty param in the query)
Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test-buildQueries.R
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ test_that("Errors are thrown if the geographical arguments are wrong",{
})

test_that("Queries work with spaces and accents",{
# Both skipping because of https://github.com/ropensci/vcr/issues/158
skip_on_os("windows")
skip_on_cran()
vcr::use_cassette("buildQueries_accents", {
result1 <- aq_measurements(city = "Heinz+Ott", country = "DE",
limit = 1, page = 1)
Expand Down

0 comments on commit dc61373

Please sign in to comment.