From c90ef0c80bcf57e6834421888b81d36bcc3c498a Mon Sep 17 00:00:00 2001 From: Sergey Linev Date: Thu, 12 Sep 2024 16:26:30 +0200 Subject: [PATCH] Remove deepscan comments No longer used for JSROOT --- modules/geom/TGeoPainter.mjs | 2 +- modules/geom/geobase.mjs | 2 +- modules/gui/HierarchyPainter.mjs | 2 +- modules/hist/TGraph2DPainter.mjs | 6 +++--- modules/hist2d/TH2Painter.mjs | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/modules/geom/TGeoPainter.mjs b/modules/geom/TGeoPainter.mjs index fd60b174b..23c080ede 100644 --- a/modules/geom/TGeoPainter.mjs +++ b/modules/geom/TGeoPainter.mjs @@ -230,7 +230,7 @@ function expandGeoObject(parent, obj) { } if (!subnodes && (shape?._typename === clTGeoCompositeShape) && shape?.fNode) { - if (!parent._childs) { // deepscan-disable-line + if (!parent._childs) { createItem(parent, shape.fNode.fLeft, 'Left'); createItem(parent, shape.fNode.fRight, 'Right'); } diff --git a/modules/geom/geobase.mjs b/modules/geom/geobase.mjs index 4e89a51d1..8b40230cd 100644 --- a/modules/geom/geobase.mjs +++ b/modules/geom/geobase.mjs @@ -2518,7 +2518,7 @@ class ClonedNodes { issimple = (clone.matrix[k] === ((k === 5) || (k === 10) || (k === 15) ? 1 : 0)); if (issimple) delete clone.matrix; } - if (clone.matrix && (kind === kindEve)) // deepscan-disable-line INSUFFICIENT_NULL_CHECK + if (clone.matrix && (kind === kindEve)) clone.abs_matrix = true; } if (shape) { diff --git a/modules/gui/HierarchyPainter.mjs b/modules/gui/HierarchyPainter.mjs index a608815da..f05cb2832 100644 --- a/modules/gui/HierarchyPainter.mjs +++ b/modules/gui/HierarchyPainter.mjs @@ -2531,7 +2531,7 @@ class HierarchyPainter extends BasePainter { hitem = d.last; } - if (hitem) { // deepscan-disable-line + if (hitem) { // check that item is visible (opened), otherwise should enable parent let prnt = hitem._parent; diff --git a/modules/hist/TGraph2DPainter.mjs b/modules/hist/TGraph2DPainter.mjs index 20a3accf0..c2c12e448 100644 --- a/modules/hist/TGraph2DPainter.mjs +++ b/modules/hist/TGraph2DPainter.mjs @@ -641,7 +641,7 @@ class TGraphDelaunay { continue; // goto L50; } - if (skip_this_triangle) break; // deepscan-disable-line + if (skip_this_triangle) break; /* Error("Interpolate", "Should not get to here"); */ // may as well soldier on @@ -679,7 +679,7 @@ class TGraphDelaunay { // vector (dx3,dy3) is expressible as a sum of the other two vectors // with positive coefficients -> i.e. it lies between the other two vectors if (l === 1) { - f = m; o1 = p; o2 = n; // deepscan-disable-line + f = m; o1 = p; o2 = n; } else if (l === 2) { f = p; o1 = n; o2 = m; } else { @@ -798,7 +798,7 @@ class TGraphDelaunay { } } } - if (shouldbein) // deepscan-disable-line + if (shouldbein) console.error(`Interpolate Point outside hull when expected inside: this point could be dodgy ${xx} ${yy} ${ntris_tried}`); return thevalue; } diff --git a/modules/hist2d/TH2Painter.mjs b/modules/hist2d/TH2Painter.mjs index a0d6c82e5..f68a22658 100644 --- a/modules/hist2d/TH2Painter.mjs +++ b/modules/hist2d/TH2Painter.mjs @@ -96,7 +96,7 @@ function buildHist2dContour(histo, handle, levels, palette, contour_func) { for (k = 0; k < 4; k++) ir[k] = LevelSearch(zc[k]); - if ((ir[0] !== ir[1]) || (ir[1] !== ir[2]) || (ir[2] !== ir[3]) || (ir[3] !== ir[0])) { // deepscan-disable-line + if ((ir[0] !== ir[1]) || (ir[1] !== ir[2]) || (ir[2] !== ir[3]) || (ir[3] !== ir[0])) { x[3] = x[0] = (arrx[i] + arrx[i+1])/2; x[2] = x[1] = (arrx[i+1] + arrx[i+2])/2; @@ -390,7 +390,7 @@ class Triangles3DHandler { // check if any(contours for given level exists if (((side1 > 0) || (side2 > 0) || (side3 > 0)) && - ((side1 !== side2) || (side2 !== side3) || (side3 !== side1))) // deepscan-disable-line + ((side1 !== side2) || (side2 !== side3) || (side3 !== side1))) ++ngridsegments; continue;