Include standard includes where required

Includes like "strlcpy.h" and "snprintf.h" are provided via Rtypes.h,
but really used only in part of the sources. Before removing them
from Rtypes.h (in dev builds) provide them all in required places

Author: linev

bindings/pyroot_legacy/src/Utility.cxx

@@ -28,11 +28,12 @@
 #include "TMethodArg.h"
 #include "TError.h"
 #include "TInterpreter.h"
+#include "snprintf.h"
 
 // Standard
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
+#include <cstdlib>
+#include <cstdio>
+#include <cstring>
 #include <algorithm>
 #include <list>
 #include <mutex>

core/base/inc/TString.h

@@ -27,6 +27,7 @@
 
 #include "ROOT/RStringView.hxx"
 #include "ROOT/TypeTraits.hxx"
+#include "snprintf.h"
 
 #include <iosfwd>
 #include <cstdarg>

core/base/src/TColor.cxx

@@ -18,6 +18,7 @@
 #include "TError.h"
 #include "TMathBase.h"
 #include "TApplication.h"
+#include "snprintf.h"
 #include <algorithm>
 #include <cmath>
 #include <iostream>

core/base/src/TDatime.cxx

@@ -26,7 +26,7 @@ required, use TTimeStamp.
 
 #include <ROOT/RConfig.hxx>
 
-#include <time.h>
+#include <ctime>
 
 #ifdef WIN32
 #include "Windows4Root.h"
@@ -35,6 +35,7 @@ required, use TTimeStamp.
 
 #include "TBuffer.h"
 #include "Strlen.h"
+#include "snprintf.h"
 #include "TDatime.h"
 #include "TError.h"
 #include "Bytes.h"

core/base/src/TDirectory.cxx

@@ -11,6 +11,7 @@
 #include <cstdlib>
 
 #include "Strlen.h"
+#include "strlcpy.h"
 #include "TDirectory.h"
 #include "TBuffer.h"
 #include "TClassTable.h"

core/base/src/TEnv.cxx

@@ -67,11 +67,12 @@ into the local file by default.
 
 #include "RConfigure.h"
 
-#include <string.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <ctype.h>
+#include <cstring>
+#include <cstdio>
+#include <cstdlib>
+#include <cctype>
 
+#include "strlcpy.h"
 #include "TEnv.h"
 #include "TROOT.h"
 #include "TSystem.h"

core/base/src/TExec.cxx

@@ -12,6 +12,7 @@
 #include <iostream>
 #include "TROOT.h"
 #include "TExec.h"
+#include "snprintf.h"
 
 ClassImp(TExec);
 

core/base/src/TFolder.cxx

@@ -84,6 +84,7 @@ if this pointer is used frequently or inside loops.
 
 #include <iostream>
 #include "Strlen.h"
+#include "strlcpy.h"
 #include "TFolder.h"
 #include "TBrowser.h"
 #include "TList.h"

core/base/src/TMacro.cxx

@@ -51,6 +51,7 @@ A macro can be written to a ROOT file via TObject::Write.
 #include "TObjString.h"
 #include "TROOT.h"
 #include "TSystem.h"
+#include "strlcpy.h"
 #include <iostream>
 #include <fstream>
 #include <sstream>

core/base/src/TObject.cxx

@@ -36,6 +36,7 @@ class hierarchies (watch out for overlaps).
 #include <iostream>
 
 #include "Varargs.h"
+#include "snprintf.h"
 #include "TObject.h"
 #include "TBuffer.h"
 #include "TClass.h"