Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorts backwards :) #18

Open
jm3 opened this issue Feb 7, 2019 · 4 comments
Open

Sorts backwards :) #18

jm3 opened this issue Feb 7, 2019 · 4 comments

Comments

@jm3
Copy link

jm3 commented Feb 7, 2019

As previously reported in #4, #6, #7, etc., users seem to consistently expect that a menu option labeled "Sort A1-Z9" will sort in the order of A1...Z9. In the past, I've seen this exact issue answered here with, "just learn the other key command," but the issue touches more than just the keyboard shortcut — the actual menu item that sorts from Z-A is labeled "Sort A-Z". So irrespective of the key command, the user currently has to remember that Sort A-Z is actually Sort Z-A.

I'm happy to fork the repo, change the two bytes, and re-release it as a plugin named, like, "Sort Intuitively" something, but that feels counterproductive since A. users would be forced to decide WHICH sorting plugin they should use, and B. you've already done the hard work of creating a great plugin, putting it on GitHub, amassing a bunch of GitHub stars, etc.

If you're still fully committed to your previously stated position, then that's fine and I'm happy to move forward with forking and releasing a new plugin. But, given that you already have a great plugin, and it seems like you should continue to "own" it, I hope you'll reconsider. Thanks for releasing such a useful plugin that I use daily!

@romashamin
Copy link
Owner

Hey, @jm3!

First, thanks for your attentiveness to previous issues. Seriously, I very appreciate it.

Second, instead of forking, would you consider to become a collaborator? I’ve switched to Figma so my Sketch plugins kinda abandoned now.

If you consider to maintain Sort Me with all responsibility, I think I’ll be totally OK if you change the sorting logic according your vision.

What do you think?

@jm3
Copy link
Author

jm3 commented Feb 18, 2019

Thanks very much for the offer, Roman! I'm not sure I'm skilled enough to take it over — I've never done CocoaScript in my life! I could take a shot at the small change to just reverse the sort order labels, but beyond that, I would have to rely mostly on contributors, as I'm not skilled in CocoaScript.

@romashamin
Copy link
Owner

@jm3, OK, of course, it’s totally for you to decide :)

Have to say, developing for Sketch is not rocket science. I still have no experience in developing for macOS or iOS and I never touched Cocoa. Modern code style looks more like JavaScript than Objective C. All you need is general programming experience.

Maybe you could start with creating your own first simple plugin to get familiar with the topic?

@bluepikachu
Copy link

Hey, @romashamin !
I would like to maintain Sort Me and I will change the sorting logic according to new version.
Can you add me as a collaborator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants