Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Add authorization #6

Open
4 of 5 tasks
lavgl opened this issue Aug 28, 2017 · 6 comments
Open
4 of 5 tasks

Add authorization #6

lavgl opened this issue Aug 28, 2017 · 6 comments

Comments

@lavgl
Copy link
Contributor

lavgl commented Aug 28, 2017

I'd like to implement auth as a next part. This covers:

  • 'Sign in' page
  • 'Sign up' page
  • Differentiating navigation menu for logged and non-logged users
  • 'Log out' button on 'Settings' page
  • Storing user info and jwt token

I suppose this functionality will be covered by several PRs.

@roman01la
Copy link
Owner

LGTM

@foopang
Copy link
Contributor

foopang commented Aug 29, 2017

Sorry for jumping in, but I have some code ready for review if you don't mind me taking this task.

@lavgl
Copy link
Contributor Author

lavgl commented Aug 29, 2017

Sure I don't. Do you want to cover all the functionality described above?

@foopang
Copy link
Contributor

foopang commented Aug 29, 2017

Yes, I have all the functionality described above covered already in #7. But the PR is not approved by @roman01la. I will try to break it down into several PRs.

@roman01la
Copy link
Owner

@foopang Thanks!

@roman01la
Copy link
Owner

@foopang One thing that might save you a bit of time: try to stick to a code style of the project as much as you can, for example component names should be camel cased starting with a capital character. Basically see how the rest of the code is written and try to write your code in same manner. We want the code base to be consistent, because this project is intended to serve as a reference for others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants