Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fr translation isn't aligned bewteen head and body #30

Open
guildem opened this issue Feb 13, 2022 · 2 comments
Open

Fr translation isn't aligned bewteen head and body #30

guildem opened this issue Feb 13, 2022 · 2 comments
Labels

Comments

@guildem
Copy link

guildem commented Feb 13, 2022

On my hosts I have this display in en :

$ LANG= /bin/dfc
FILESYSTEM     (=) USED      FREE (-)  %USED AVAILABLE  TOTAL MOUNTED ON
dev            [--------------------]   0.0%      7.8G   7.8G /dev
run            [=-------------------]   0.0%      7.8G   7.8G /run
/dev/nvme0n1p2 [==========----------]  46.3%    251.5G 468.0G /
tmpfs          [=-------------------]   0.0%      7.8G   7.8G /dev/shm
tmpfs          [--------------------]   0.0%      4.0M   4.0M /sys/fs/cgroup
tmpfs          [=-------------------]   0.0%      7.8G   7.8G /tmp
/dev/nvme0n1p1 [=====---------------]  24.9%    383.6M 511.0M /boot
tmpfs          [=-------------------]   0.0%      1.6G   1.6G /run/user/1000

And I have this display on fr :

$ LANG=fr_FR.UTF-8 /bin/dfc -Tw
SYSTÈME DE FICHIERS TYPE     (=)  UT.                                    LIB. (-)  %UTILISÉ DISPO.  TOTAL MONTÉ SUR
dev                  devtmpfs [--------------------------------------------------]       0,0%   7,8G   7,8G /dev
run                  tmpfs    [=-------------------------------------------------]       0,0%   7,8G   7,8G /run
/dev/nvme0n1p2       ext4     [========================--------------------------]      46,3% 251,5G 468,0G /
tmpfs                tmpfs    [=-------------------------------------------------]       0,0%   7,8G   7,8G /dev/shm
tmpfs                tmpfs    [--------------------------------------------------]       0,0%   4,0M   4,0M /sys/fs/cgroup
tmpfs                tmpfs    [=-------------------------------------------------]       0,0%   7,8G   7,8G /tmp
/dev/nvme0n1p1       vfat     [=============-------------------------------------]      24,9% 383,6M 511,0M /boot
tmpfs                tmpfs    [=-------------------------------------------------]       0,0%   1,6G   1,6G /run/user/1000

po files seems ok, and I tried to debug it, but I'm not able to test debug or release compiled bin in fr, I must forget something (never tried to work with gettext in c yet).

Can I test something else to help ? Is there any way to test it myself ?

@rolinh rolinh added the bug label Feb 15, 2022
@rolinh
Copy link
Owner

rolinh commented Feb 15, 2022

Thanks for the report. How important is translation to you? I've been considering dropping translation support for a while now given that it's a pain to maintain. In this case, for correct text output, the headers MUST be of the same length regardless of the language, which is apparently not the case anymore.

@guildem
Copy link
Author

guildem commented Feb 15, 2022

When checking the code, I was thinking that col width was managed, and that custom length was authorized. Am I wrong ?
I won't stop using dfc because of a lack of translations, bug they can be useful for some people.

If you have a list of devices, you can do a first check of them to validate the max length, and compare it with the header. Then you draw the header/body lines. I was convinced that already was the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants