Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessions returned as Hash.with_indifferent_access? #71

Open
toldani opened this issue Jun 27, 2016 · 2 comments
Open

sessions returned as Hash.with_indifferent_access? #71

toldani opened this issue Jun 27, 2016 · 2 comments
Assignees
Labels

Comments

@toldani
Copy link

toldani commented Jun 27, 2016

I forked this repo to add .with_indifferent_access to the hash that the session returned. It was causing issues with some of our previously-written code, but this seemed to fix it:

https://github.com/toldani/redis-session-store

@meatballhat
Copy link
Collaborator

@toldani Hey, thanks for letting us know. Given that Hash#with_indifferent_access isn't part of the ruby stdlib, I assume you're depending on the one that comes with ActiveSupport. This gem doesn't currently depend on ActiveSupport, and I think that adding it as a runtime dependency should be carefully considered. Altering your patch to conditionally invoke Hash#with_indifferent_access would be a reasonable compromise, imho 😸 Please open a pull request if you like!

@olleolleolle
Copy link
Contributor

@toldani @meatballhat It seems this Issue has been fixed by #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants